Make toolbar button icons and high contrast menu and disabled text follow the surrounding text color
Categories
(Toolkit :: Themes, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(3 external files)
Outside Nova, toolbar button icons use fixed grays (color.gray.70 in light, color.gray.0 in dark). Under prefers-contrast, disabled ghost button text and menu item text use fixed colors too. On a surface whose text color differs, these don't match the text around them. For example, under prefers-contrast the app menu panel paints CanvasText, but its enabled items keep a fixed color.
Deriving these values from currentColor makes them follow the surface they're drawn on. The light icon fill becomes a color-mix() of currentColor with transparent. Nova keeps its fixed icon colors.
| Assignee | ||
Comment 1•29 days ago
|
||
The light icon fill mixes 69% of currentColor with transparent, which matches the old color.gray.70 over the default light toolbar. Nova keeps its fixed icon colors, so the fill rules stay in @media (forced-colors).
Outside Nova in light, hovered and pressed icons get 12-27 levels darker because the translucent fill composites over the hover and active backgrounds. Under prefers-contrast, menu items take the panel's text color.
Updated•29 days ago
|
| Assignee | ||
Comment 2•29 days ago
|
||
Figma's dark values for disabled, hovered, pressed and selected menu items never painted: in chrome the ghost tokens are inherit, which invalidates the whole light-dark() so the color inherits, and in-content both sides already resolve to the same color.
| Assignee | ||
Comment 3•29 days ago
|
||
A token set to inherit leaves the custom property empty, so it only works where no light-dark() or color-mix() wraps it; currentColor stays valid there. Every reader sets color, where the two compute the same.
| Assignee | ||
Updated•28 days ago
|
Comment 5•28 days ago
|
||
| bugherder | ||
Comment 7•23 days ago
|
||
| bugherder | ||
| Assignee | ||
Updated•18 days ago
|
Updated•10 days ago
|
Description
•