Closed Bug 2085331 Opened 28 days ago Closed 16 days ago

Move more of the desktop-theme skills' product knowledge into the CSS guidelines and design-token docs

Categories

(Developer Infrastructure :: Source Documentation, task)

task

Tracking

(firefox161 fixed)

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(13 external files)

A second round of bug 2071602. Facts the desktop-theme agent skills hold about how Firefox styling works belong in the in-tree docs, where human contributors read them too and the skills can point to them. Landing them ahead of the skills (bug 2071613) also shrinks the skills patch under review.

This round starts with corrections to the CSS guidelines (env(hairline) and the forced-colors border-color fallbacks) and a design-token README section on importing from Figma, and may take more of the CSS guidelines material listed in the meta bug's plan.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

The page said a lightweight theme applies the native theme; it paints the nativeTheme values from tokens-foundation while (-moz-native-theme) reads false for it.

Attachment #9667331 - Attachment description: Bug 2085331 - Correct the theme support, content color scheme, forced-color and chrome-rule facts in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Correct the theme support, content color scheme, forced-color and chrome-rule facts in the CSS guidelines. r?tgiles!
Attachment #9667332 - Attachment description: Bug 2085331 - Document which color properties the forced-color adjustment filters, and how to force colors on chrome, in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Document which color properties the forced-color adjustment filters, and how to force colors on chrome, in the CSS guidelines. r?tgiles!
Attachment #9667333 - Attachment description: Bug 2085331 - Document how an auto outline paints focus rings in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Document how an auto outline paints focus rings in the CSS guidelines. r?tgiles!
Attachment #9667334 - Attachment description: Bug 2085331 - Document UI density and popup font sizes in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Document UI density and popup font sizes in the CSS guidelines. r?tgiles!
Attachment #9667335 - Attachment description: Bug 2085331 - Document which widths snap to device pixels and the ratio a scaling pref runs at in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Document which widths snap to device pixels and the ratio a scaling pref runs at in the CSS guidelines. r?tgiles!
Attachment #9667336 - Attachment description: Bug 2085331 - Document that browser_parsable_css.js fails an unreferenced custom property in the CSS guidelines. r?#desktop-theme-reviewers → Bug 2085331 - Document that browser_parsable_css.js fails an unreferenced custom property in the CSS guidelines. r?tgiles!
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/51da265b0d62 https://hg.mozilla.org/integration/autoland/rev/3c43ef122eea Correct the env(hairline) fallback and the forced-colors border-color fallbacks in the CSS guidelines. r=desktop-theme-reviewers,tgiles https://github.com/mozilla-firefox/firefox/commit/ccfbefcac20d https://hg.mozilla.org/integration/autoland/rev/8788ed5f2dac Document how ./mach buildtokens --import-figma brings Figma values into the Nova token overrides. r=desktop-theme-reviewers,reusable-components-reviewers,tgiles https://github.com/mozilla-firefox/firefox/commit/fd6d89225b9d https://hg.mozilla.org/integration/autoland/rev/c30f6bba5ba9 Correct the theme support, content color scheme, forced-color and chrome-rule facts in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/7eac7c68c680 https://hg.mozilla.org/integration/autoland/rev/286cc1d11bf1 Document which color properties the forced-color adjustment filters, and how to force colors on chrome, in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/6189cdf260d6 https://hg.mozilla.org/integration/autoland/rev/b413624f2da9 Document how an auto outline paints focus rings in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/57f502085c6b https://hg.mozilla.org/integration/autoland/rev/85656b946489 Document UI density and popup font sizes in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/6049ec14b0d3 https://hg.mozilla.org/integration/autoland/rev/53d9b0205ac5 Document which widths snap to device pixels and the ratio a scaling pref runs at in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/2f402d072d99 https://hg.mozilla.org/integration/autoland/rev/232eb568272a Document that browser_parsable_css.js fails an unreferenced custom property in the CSS guidelines. r=tgiles https://github.com/mozilla-firefox/firefox/commit/40ff4740090a https://hg.mozilla.org/integration/autoland/rev/5d7e0e1cfe95 Fix the design token docs' dead links and their account of which layer each theme paints. r=tgiles,reusable-components-reviewers,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/178abc54e034 https://hg.mozilla.org/integration/autoland/rev/79880dc5e13c Document how the design token layer order is generated. r=tgiles,reusable-components-reviewers,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/ed400b6d46e5 https://hg.mozilla.org/integration/autoland/rev/34b7b3e8dcd9 Document where the design token generator reads and writes, and where it writes a token's comment. r=tgiles,reusable-components-reviewers,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/3693b1038e08 https://hg.mozilla.org/integration/autoland/rev/2958bd98876e Document the built-in theme manifests generated from token JSON. r=tgiles,reusable-components-reviewers,desktop-theme-reviewers https://github.com/mozilla-firefox/firefox/commit/d6cb1bd01c53 https://hg.mozilla.org/integration/autoland/rev/c8a1d641c509 Document what the design token tests cover. r=tgiles,reusable-components-reviewers,desktop-theme-reviewers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: