Closed Bug 2086034 Opened 24 days ago Closed 24 days ago

Autofill Rust migration telemetry reports no error_message when a record is rejected by an OS key store error

Categories

(Toolkit :: Form Autofill, task, P2)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [fxcm-backlog])

Attachments

(1 external file)

The migrate_to_rust event leaves out error_message when the error has an empty message. XPCOM exceptions from OSKeyStore.decrypt have an empty .message, so every rejected-record run in the credit card dry run (bug 2081661) reported no reason. The message should fall back to the error's result name, e.g. NS_ERROR_FAILURE.

An XPCOM exception from the OS key store has an empty message, so every run
that rejected a record reported no error_message.

Pushed by dlee@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8d382fe9df2e https://hg.mozilla.org/integration/autoland/rev/a3107705c3ae Name the result of an autofill migration error that has no message. r=credential-management-reviewers,theidkamp
Whiteboard: [fxcm-backlog]
Status: ASSIGNED → RESOLVED
Closed: 24 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
See Also: → 2089931
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: