2086303 - about:keyboard shows "(cannot be changed)" instead of "(set in macOS keyboard settings)" for unchangeable shortcuts assigned in System Settings

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Stephen A Pohl [:spohl]]

On macOS, a shortcut can be assigned to a Firefox menu item in System Settings (bug 1333781). about:keyboard then shows "(set in macOS keyboard settings)" below the action, but for the shortcuts it marks as unchangeable (Undo, Redo, Cut, Copy, Paste, Select All, Settings, Hide, Quit and Minimize) it keeps showing "(cannot be changed)" instead, while the shortcut column shows the assigned shortcut.

Steps:

1. In System Settings > "Keyboard" > "Keyboard Shortcuts…" > "App Shortcuts", assign a shortcut to "Settings…" for Firefox Nightly.
2. Open about:keyboard and find "Settings".

Expected: "(set in macOS keyboard settings)" below "Settings", as for other shortcuts assigned in System Settings.
Actual: "(cannot be changed)".

about:keyboard should show where the shortcut comes from for these shortcuts too. Found by QA while testing bug 1333781 (QA-5854).

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 2086303: Show "(set in macOS keyboard settings)" in about:keyboard for unchangeable shortcuts assigned in System Settings. r?Jamie

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Bug 2086303: Make a shortcut assigned in System Settings replace the built-in shortcut of internal menu items. r?#mac-reviewers!,Jamie

The built-in shortcuts of Undo, Redo, Cut, Copy, Paste and Select All are handled in ShortcutKeyDefinitions.cpp, because their key elements, or the commands those point to as in the Library window, are internal. So rewriting the key element did not stop them, and both the assigned and the built-in shortcut worked. While another shortcut is assigned to such an item, the menu bar now stops its built-in shortcut, so the key does nothing.

Comment 3

[Stephen A Pohl [:spohl]]

(Trying to add a QA whiteboard tag to have this picked up as part of QA-5854 test coverage. Monica, please adjust if I didn't do this right. Thank you!)

Comment 4

[Stephen A Pohl [:spohl]]

Try push: https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=111517

Comment 5

[Monica Chiorean]

Removing the NI from me as I mentioned to Stephen on slack, that the treeherder build did not worked for me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88f3f904f443
https://hg.mozilla.org/integration/autoland/rev/d093f5bc7b3c
Show "(set in macOS keyboard settings)" in about:keyboard for unchangeable shortcuts assigned in System Settings. r=Jamie
https://github.com/mozilla-firefox/firefox/commit/cd8b1382296c
https://hg.mozilla.org/integration/autoland/rev/8babe70ccb9c
Make a shortcut assigned in System Settings replace the built-in shortcut of internal menu items. r=Jamie,mac-reviewers,bradwerth

Comment 7

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/d093f5bc7b3c
https://hg.mozilla.org/mozilla-central/rev/8babe70ccb9c

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.

:spohl, please make an uplift decision for beta:

• For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox161 to wontfix if the fix can wait for the next release.

Uplift requests can be submitted from Lando: D337342, D337857.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Comment 9

[Stephen A Pohl [:spohl]]

I don't believe that this needs to be uplifted and can probably ride the trains.