Open Bug 2091722 Opened 4 days ago Updated 3 days ago

The keyboard shortcuts for cut, copy, and paste that I assigned in macOS System Settings are not working

Categories

(Core :: Widget: Cocoa, defect)

Firefox 161
defect

Tracking

()

ASSIGNED

People

(Reporter: 5silentrain, Assigned: spohl, NeedInfo)

References

Details

Attachments

(2 files, 2 external files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:160.0) Gecko/20100101 Firefox/160.0

Steps to reproduce

I'm left-handed, so in macOS System Settings, I've assigned F13, F14, and F15 to cut, copy, and paste (I have a full-size Apple keyboard). And not specifically for Firefox, but globally, for ALL applications. These keys (F13, F14, and F15) work fine in all system applications, including Chrome and Safari. I specifically waited for Firefox version 161 to be released because Stephen A. Pohl finally closed bug report 1333781, meaning this issue was finally supposed to be resolved. But alas! I open any website (let's say this one: https://trn-audio.com/), select any text and press F14 to copy it, but it doesn't copy! This means that bug report number 1333781 is still not fully resolved.

Actual results

N/A

Expected results

N/A

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Widget: Cocoa
Product: Firefox → Core

It's also strange that F13, F14 and F15 work in the address bar 🤨 Maybe they work somewhere else, I don't know 🤔 The most annoying thing is that for some reason they still don't work on regular websites 😠 🙁

Firefox 161 hasn't been released yet. It's currently in beta, and the build you filed this from is Firefox 160 according to its user agent, which doesn't include the changes from bug 1333781.

If you haven't done so already, could you try this in Firefox Developer Edition 161 (I see it's installed in your screenshot) or in Firefox Beta 161, and let us know whether F13, F14 and F15 work for cut, copy and paste on regular web pages there?

Flags: needinfo?(5silentrain)

Of course, I tested this in Firefox Developer Edition 161.0b1 and 161.0b2! 🙂

Flags: needinfo?(5silentrain)

A key point to note is that I’ve assigned the F13, F14, and F15 keys to "cut," "copy," and "paste" GLOBALLY, so that they work in every single application. And they work everywhere—except in Firefox! :(

Thank you! I believe I have this isolated. Working on a fix...

I have a fix for this that I'm verifying locally now. Function keys, arrow keys, Home, End and a few other keys weren't being matched to shortcuts assigned in System Settings, so they fell through to the web page instead of triggering the menu item.

While looking into this, I realized that this is going to get worse in Firefox 162. Bug 2086303 makes Firefox ignore a menu item's built-in shortcut once a different shortcut has been assigned to it in System Settings, which matches what macOS does in other apps. With F14 assigned to "Copy", that means Cmd+C should no longer copy either, so without this fix there would be no keyboard shortcut left for copying on web pages. The same goes for "Cut" and "Paste" with F13 and F15. So we should land this fix in Firefox 162.

Blocks: 2086303

No functional changes. This lets a gtest call it in the next patch.

Assignee: nobody → spohl.mozilla.bugs
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The keyboard layout gives these keys a control character, such as 0x10 for every function key, rather than no character, so they were compared against the layout's character and never matched the key equivalent AppKit uses, such as NSF14FunctionKey. They are now compared through the event's own character.

Great!!! 👏 If this finally works in the next stable version (version 161), like in Chrome, Safari, and any other app, it will be the best New Year's gift 🎁 🎊 🎉 🥳 🎄I've been patiently waiting for this for about six years now ⏳ I was even starting to think this would never be implemented in Firefox and that it would be easier to just switch to Chrome or Safari...

Not to distract too much from the bug at hand, but I see that you reacted to my bug 1333781 comment 57. I can genuinely say that I never had the opportunity to write a release note like this before. Not having the ability to set your shortcuts in system settings has been something that has been been bothering me for a very, very long time. I'm very happy that we were finally able to add this functionality, and your bug reports are enabling us to complete this functionality end-to-end. So, thank you!

I can't promise that the fix will be in Firefox 161, but I'm hoping at least in 162.

If you feel so inclined, could you check whether this try build fixes it for you? Paste this into Terminal:

cd ~/Downloads && mkdir -p firefox-try-2091722 && cd firefox-try-2091722 && curl -L -o target.tar.gz "https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/E7NvftlHRnW4kYB6DwVJEQ/artifacts/public/build/target.tar.gz" && tar -xzf target.tar.gz && mkdir -p profile appdata cache && MOZ_APP_DATA="$PWD/appdata" MOZ_LOCAL_APP_DATA="$PWD/cache" ./Firefox\ Nightly.app/Contents/MacOS/firefox --new-instance -profile "$PWD/profile"

It starts with a fresh profile, so click "Continue" on the welcome screen. Then open any web page with a text field and try cut, copy and paste with F13, F14 and F15.

Please let me know whether they work. Afterwards you can delete the firefox-try-2091722 folder in your Downloads folder. Thanks again!

Flags: needinfo?(5silentrain)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: