2086761 - Ctrl+V occasionally sends the email before it's ready.

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Eugene Savitsky]

Lately (release 147/148+) I experienced a few times that hipping CTRL-V sends the not ready e-mail out.

Windows 10.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 2086761 - Improve the shortcut modifier matching to prevent false positive. r=mkmelin

Comment 2

[Alessandro Castellani [:aleca]]

I'm not able to reproduce the issue but while investigating I found out that the shortcut modifiers matching could be prone to false positive. I doubt this is the root cause but better to strengthen the logic.

The only incident in which I was able to maybe reproduce it was when I pressed CTRL+V and Enter very fast right after to paste something and go to the next line.
In that occasion the CTRL modifier was still slightly pressed so it triggered the sending.
But I was able to simulate and reproduce this scenario also in 146 before the changes to the keyboard shortcut.

Comment 3

[Eugene Savitsky]

It does not happens every time or day. Time to time, may be one time in few days.

Comment 4

[:mole]

I feel like that's how it happens to me too. Like it's my fault for still holding Ctrl when I make a new line, but I never had a problem with that before version 158.

Comment 5

[Michel]

Ctrl+Enter by default produces a warning popup: "Are you sure you are ready to send this message?"

You possibly turned that off by checking "Do not show me this dialogue box again."

You can turn it back on in Settings > Composition: check "Confirm when using keyboard shortcut to send message."

Comment 6

[Eugene Savitsky]

I disable that dialog immediately and had no problems until recent weeks.

The mail sends out what I'm typing and i'm 99,9% sure it happens when I write one sentence, without hitting the Enter.

BTW I have experienced a few times now: when I write a mail in a window and some new reply windows poping up,
as I would hold CTRL and R, when the main windows has focus. But i'm not 100% sure how it works yet. I just had one today.
Maybe it's the same roots.

Comment 7

[Glyph]

Having this issue too. I found out that it often happens when you press enter to add an paragraph and then quickly after that you insert a link or a snippet from your clipboard using Ctrl+V. So it seems to be an issue with the sequence Enter+Ctrl+V. I tried to write slowly and the issue never appeared. Sadly I often forgot and send the unfinished e-mail accidentally anyway :)

Comment 8

[Alessandro Castellani [:aleca]]

Thanks for the extra info.
This seems to confirm that in some instances the shortcuts overlap with each other and they can be triggered if multiple keys are released at the same time.
I was able to reproduce it by quickly pressing Enter and then CTRL+V.
I suspect this is due to the fact that the CTRL+Enter shortcuts is handled by Thunderbird via JavaScript while the copy/paste command is handled via XUL keys, therefore the 2 methods could coexist and overlap each other.
I might be able to safeguard against this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8e758524c54e
Improve the shortcut modifier matching to prevent false positive. r=mkmelin

Comment 11

[Max Emig [:maxe]]

I hope I am not making anyone upset by sending this, the real regressor is bug 620853 and the real fix landed under bug 2083823 within a day of this.

The patch landed here (D337816) appears to be a NOOP, potentially useful for the future, though, would not back out.

Comment 12

[Alessandro Castellani [:aleca]]

Thanks Max for confirming this.
Yes, I know that the current patch in this bug is not really a fix for the issue but more of a strengthening of the shortcut logic matching.
I'll tentatively mark this as fixed as it seems that the reports and accidental triggers have stopped.