Closed Bug 2087595 Opened 17 days ago Closed 13 days ago

Add a stub Wrexham AFC widget to New Tab hidden and disabled by default

Categories

(Firefox :: Widgets, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: mconley, Assigned: mconley, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hnt][hnt-wattle])

Attachments

(1 external file)

Add a Wrexham AFC widget to New Tab as a regular widget registry entry, to build out under bug 2087516. It is off and hidden by default; the main audience is the Wrexham repack, which can turn it on with default prefs via distribution.ini.

It adds:

  • A wrexhamAFC entry in WIDGET_REGISTRY, drawn by MozWidgetCard, with the club crest (the existing tippytop image) as its header icon.
  • A menu with "View" (Matches, Table or Fixtures, stored in widgets.wrexhamAFC.view) and "Wallpapers" (opens the Customize panel).
  • widgets.wrexhamAFC.enabled, widgets.system.wrexhamAFC.enabled, widgets.wrexhamAFC.size and widgets.wrexhamAFC.view prefs. Both enabled prefs default to false, so the widget is neither shown nor offered in the Customize panel until something enables them, such as the repack's distribution.ini.
  • Its strings live in newtabPreview.ftl for now, so they are not yet exposed to localizers. The widget name may later need a Welsh translation ("CPD Wrecsam").
  • It has no document to frame yet, so its card shows a placeholder. The endpoint can later be set as the entry's src or through trainhopConfig.widgetWrexhamAFC.src.

Everything lives under browser/extensions/newtab/ and browser/locales-preview/, so it can ship with New Tab train-hops. I initially planned on using the WebExtension API with a built-in addon, but considering the aggressive timeline, it seems like being able to trainhop changes to the widget shell would be wise, at least for now. There's a future where this gets spun out into a built-in addon (and then later, spun out as a normal WebExtension once the widget WebExtension API matures and becomes generally available).

Whiteboard: [hnt][hnt-wattle]
Assignee: nobody → mconley
Attachment #9671811 - Attachment description: WIP: Bug 2087595 - Add a stub Wrexham AFC widget to New Tab. r?fchasen! → Bug 2087595 - Add a stub Wrexham AFC widget to New Tab. r?fchasen!
Status: NEW → ASSIGNED
See Also: → 2088174
Pushed by nfay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/060c47bd4e08 https://hg.mozilla.org/integration/autoland/rev/9da10dccdc90 Revert "Bug 2087595, Bug 2087597, Bug 2087591 - Add a stub Wrexham AFC widget to New Tab. r=fchasen,fluent-reviewers,bolsson" for causing failure @ browser_wrexhamafc_widget.js

Backed out for causing failure @ browser_wrexhamafc_widget.js

Backout link

Push with failures

Failure log

Flags: needinfo?(mconley)
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ff833275969c https://hg.mozilla.org/integration/autoland/rev/80951c45b4b8 Revert "Bug 2087595 - Add a stub Wrexham AFC widget to New Tab. r=fchasen,fluent-reviewers,bolsson" for causing bc failures @ browser_wrexhamafc_widget.js
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: