208827 - Default Attachment Creation to "autodetect"

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Jon Wilmoth]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

As a user convenience the create.html.tmpl template should default 
the "contenttypemethod" radio button group to the "autodetect" value.

Reproducible: Always

Steps to Reproduce:
1. Goto an existing issue
2. Click the "Create a New Attachment" hyperlink
3.

Comment 1

[Jon Wilmoth]

Attachment: Patch to default the attachment type to "autodetect"

sets the autodetect radio button option as the default.

Comment 2

[Dave Miller [:justdave]]

hmm, that sounds worthy :)

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 125250 [details] [diff] [review]
Patch to default the attachment type to "autodetect"

Whew, lots of whitespace changes in that patch.  I'm not real concerned about
those though.

The reason for the negative review is the "CHECKED" should be lowercase to
conform with the rest of the html.  We may even have a little argument over
whether it should be |checked| or |checked="checked"| so I'll need to find a
few opinions on that. :)

Comment 4

[Bradley Baetz (:bbaetz)]

checked="checked" for valid html4.

I should probably run gmuck over the files again at some point.

Comment 5

[Jon Wilmoth]

Attachment: html4 compliant revision of previous patch

made html 4 compliant by changeing input element checked attribute to
checked="checked"

Comment 6

[Vlad Dascalu]

Attachment: Previous patch without the space changes

An alternative patch if you want to ingore the space-changes made by the
previous one.

Comment 7

[Christian Reis]

Comment on attachment 125761 [details] [diff] [review]
html4 compliant revision of previous patch

r=kiko. The whitespace changes are okay by me, but either is fine

Next time ou might want to do a diff -b to avoid the whitespace slowing down
review.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

*** Bug 140480 has been marked as a duplicate of this bug. ***

Comment 9

[Myk Melez [:myk] [@mykmelez]]

I think bug 85132 should be fixed before this patch goes in, since otherwise
auto-detect will fail a lot.

Comment 10

[Jouni Heikniemi]

Comment on attachment 128283 [details] [diff] [review]
Previous patch without the space changes

I'd rather go for the one without whitespace changes to avoid unnecessary
possible problems with annotate listings becoming illogal, whitespace changes
causing conflicts when backing out this patch and so on.

Comment 11

[Max Kanat-Alexander]

What's the deal with this? We have some review+ patches here... and they're
after the time that approval was asked for.

Comment 12

[Vlad Dascalu]

Targeting bug to 2.20 since the 2.20 feature freeze was canceled.

Comment 13

[Myk Melez [:myk] [@mykmelez]]

This one is still awaiting a fix for bug 85132.

Comment 14

[Myk Melez [:myk] [@mykmelez]]

Actually, scratch that.  Experience shows that auto-detect does a good enough
job enough of the time that we don't need to get magic integrated first before
we do this.

Comment 15

[Olav Vitters]

Requesting approval based on comment 14.

Comment 16

[Dave Miller [:justdave]]

wow, patch still applies cleanly. :)  Vlad: care to do the honors, since it's your patch?  If not, LpSolit will probably get it in the next day or so.

Comment 17

[Frédéric Buclin]

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.22; previous revision: 1.21
done

Comment 18

[Vlad Dascalu]

Thanks for the check in, LpSolit!

Comment 19

[Frédéric Buclin]

*** Bug 327625 has been marked as a duplicate of this bug. ***