Closed Bug 2090433 Opened 12 days ago Closed 6 days ago

Scaled elliptical CSS borders paint horizontal/vertical lines through their empty centres

Categories

(Core :: Graphics: WebRender, defect)

Firefox 157
defect

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr153 --- unaffected
firefox160 --- wontfix
firefox161 --- wontfix
firefox162 --- fixed

People

(Reporter: qqddev, Assigned: gw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files, 1 external file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:157.0) Gecko/20100101 Firefox/157.0

Steps to reproduce

open attached firefox-ellipse-border.html

Actual results

ellipse has line in it

Expected results

ellipse should be empty

Attached image screenshot —

Lines only appear at certain scales. For the given firefox-ellipse-border.html, they appear at 100% display scaling and 100% page zoom, but also at 125% display scaling and 80% page zoom.
Lines are not visible on Firefox's WebDriver screenshot of the same page.
Possibly a regression of https://bugzilla.mozilla.org/show_bug.cgi?id=1404158

Component: Untriaged → Graphics: WebRender
Product: Firefox → Core
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All

mozregression with --pref "layout.css.devPixelsPerPx:'1.0'" and the testcase I just attached (testcase_animated_hold.html) reproduces for me on mac.

Set release status flags based on info from the regressing bug 2062877

:gw, since you are the author of the regressor, bug 2062877, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

The corner geometry was scaled by the nominal raster scale, but the task is
sized by rounding the box at that scale and then stretched onto the box. When
the box isn't a whole number of texels (a power-of-2 scale under an animated
transform, or MAX_BORDER_RESOLUTION clamping), the arc's clip centre could fall
inside the task, and the shader fills the strip beyond it solid, drawing lines
through elliptical borders.

Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mozilla)
Duplicate of this bug: 2090579
Pushed by gwatson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7534aea0c376 https://hg.mozilla.org/integration/autoland/rev/78a0002970b0 Map border segment geometry into its task with the task's own stretch. r=gfx-reviewers,nical
Status: ASSIGNED → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch

The patch landed in nightly and beta is affected.

:gw, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox161 to wontfix if the fix can wait for the next release.

Uplift requests can be submitted from Lando: D340774.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(mozilla)

This has existed for 2-3 months, so can ship with the trains I think.

Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: