1404158 - border-radius produces additional lines

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2017-09-29_00-57-21.mp4

Nightly 58 x64 20170928100123 de_DE @ Debian Testing (KDE / Radeon RX480)
gpu-process + layers force accel + webrender (layersfree) + webrendest
This happens in all modes.

Its looking like a "T" that's lying on the side. If I resize the window, the lines may hide and reappear.

This is only if a div contains text. See attached video.

* you might have seen it in 1403976 comment 1, but I didn't mention it there
* twitter's login button looks the same

Comment 1

[Darkspirit]

Attachment: wr-testcase.html

Comment 2

[Darkspirit]

missing word.
> * you might have seen it in bug 1403976 comment 1, but I didn't mention it there

Comment 3

[Darkspirit]

Also seen on Cloudflare (you have to login and add a domain) on the Caching page: Their custom radio buttons have a horizontal line (diameter) that flicker while scrolling like in comment 0 and comment 1.

Comment 4

[Darkspirit]

mstange: Is this a WebRender bug (something for GitHub) or is this caused by a yet missing feature/Firefox integration?

Comment 5

[Markus Stange [:mstange]]

Probably a WebRender bug, because Gecko doesn't split off the corners from the rest of the border; it forwards along the full border as one shape. And rounded borders are a fully supported feature now.
It might also be a driver bug because I can't reproduce the issue on my Mac.

Could you file an issue on GitHub?

Comment 6

[Darkspirit]

https://github.com/servo/webrender/issues/1805

Comment 8

[Darkspirit]

Attachment: 2017-10-13_Windows10-1703.png

Nightly 58 x64 20171013100112 de_DE @ Windows 10 1703 (Radeon RX480)
fresh profile: webrender + webrendest + blob-images (&disabled pocket/GMP/EME)

I can see those lines even on divs without text.

Comment 10

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Screen Shot 2017-10-19 at 4.16.39 PM.png

I can reproduce it on my Macbook pro with nvidia GT750M

See the strange cross inside the spinner below.

But weird enough, I didn't see lines when I open the test page in the attachment.

Comment 11

[Darkspirit]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #10)
> But weird enough, I didn't see lines when I open the test page in the attachment.

Try to zoom in and/or resize the window. (Maybe this is a bit like bug 1401665 comment 7.)

Comment 12

[Michael Leu[:Lenzak](UTC+8)]

OH, I see the strange lines in the test page.

It seems that the bogus line only present in some zoom ratio.

Comment 13

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1404158 - Only draw vertical and horizontal edge when border radius is less then border width

Review commit: https://reviewboard.mozilla.org/r/195352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195352/

Comment 14

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8924114 [details]
Bug 1404158 - Only draw vertical and horizontal edge when border radius is less then border width

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195352/diff/1-2/

Comment 16

[Darkspirit]

Verified fixed in Nightly 58 x64 20171104100412 de_DE @ Debian Testing (KDE, Radeon RX480). Thank you!!

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=8913468
YouTube: Loading circle on https://www.youtube.com/watch?v=W_ve0qDCr2k
Twitter: login/register buttons
Cloudflare: Radio buttons on caching page

layers.acceleration.force-enabled, gfx.webrender.enabled
mozregression --bad 2017-11-03 --good 2017-11-04 --profile-persistence clone-first --find-fix
(a few builds were broken)
> 12:51.10 INFO: First good revision: f7af48305978405e52c1b61920b3a51746249579
> 12:51.10 INFO: Last bad revision: 4dc4eae45e0a8c6562692a8509b512a8b6a088cb
> 12:51.10 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4dc4eae45e0a8c6562692a8509b512a8b6a088cb&tochange=f7af48305978405e52c1b61920b3a51746249579

Fixed by https://github.com/servo/webrender/pull/1975 which is included in bug 1413178 comment 10.
GitHub issue: https://github.com/servo/webrender/issues/1805

(Could you mark this as fixed?)

Comment 17

[Markus Stange [:mstange]]

Fixed by the webrender update in bug 1413178.