Remove unused geckoview-junit command
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox162 fixed)
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: owlish, Assigned: owlish)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(1 external file)
run_geckoview_junit in testing/mochitest/mach_test_package_commands.py does:
# Force fission disabled by default for android
args["disable_fission"] = True
args is an argparse.Namespace, built at the call site as args = Namespace(**kwargs) and accessed by attribute everywhere else, including in set_android_args which sets args.app, args.utilityPath and so on. A Namespace does not implement __setitem__, so this line raises:
TypeError: Namespace object does not support item assignment
That happens before run_test_harness is reached, so running geckoview-junit through the test package mach command cannot work at all.
The line was added in 2022 by bug 1762991, so it has been broken for a long time without anyone noticing, which suggests nothing exercises this code path. CI runs geckoview-junit through mozharness and runjunit.py directly rather than through this wrapper.
Since the command is not used anyway, the suggested fix is to remove it altogether.
Updated•6 days ago
|
| Assignee | ||
Updated•6 days ago
|
| Assignee | ||
Comment 1•6 days ago
|
||
Updated•6 days ago
|
| Assignee | ||
Updated•6 days ago
|
Updated•3 days ago
|
| Assignee | ||
Updated•3 days ago
|
Description
•