209383 - middle-click on bookmark folder in sidebar also pastes into first tab

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[jay]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030613
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030613

A middle-click on a bookmark folder in the Bookmarks sidebar tab should open the
bookmarks in that folder as tabs, but if there is content in the clipboard, it
is pasted into the first window.  If the clipboard is a URL, that URL is opened
instead of the first bookmark.  If the clipboard is other text, it is either
searched for (if Internet Keywords are enabled), or an error about an invalid
URL is displayed.

Reproducible: Always

Steps to Reproduce:
1. select some text in a web page
2. middle-click a folder in the Bookmarks sidebar tab

Actual Results:  
2nd and following bookmarks in folder opened as tabs, but first tab contains
search results for text that had been selected

Expected Results:  
all bookmarks in folder opened in separate tabs

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like someone is forgetting to cancel an event....

Comment 2

[R.K.Aa.]

WFM, current trunk CVS, Linux.

Comment 3

[Stefan Borggraefe]

This only happens when middlemouse.contentLoadURL is set to true.

Confirming with a three day old Linux gtk2 trunk build.

Comment 4

[Wladimir Palant]

This is a dup of bug 171792 IMO.

Comment 5

[Wladimir Palant]

Attachment: Fix for Bookmarks and History sidebars

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 159557 [details] [diff] [review]
Fix for Bookmarks and History sidebars

sr=jst

Comment 7

[Wladimir Palant]

Attachment: Regression patch

This fixes the regression caused by bug 257405. AFAICT this is the only place
where we need a check.

Comment 8

[Wladimir Palant]

Comment on attachment 160496 [details] [diff] [review]
Regression patch

Sorry, wrong bug :-(

Comment 9

[Stefan Borggraefe]

Fix checked in.