209509 - Download window opens when saving an image (don't show for cached content)

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Downloading, defect)

Description

[Bernard Quince]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030306 Camino/0.7
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20030306 Camino/0.7

The down load window appears when I try to save an image (cntl and mouse click),
this is very annoying especially as it grows. The completed saves remain on the
list and need to be removed mannually.



Reproducible: Always

Steps to Reproduce:
1.find a graphi/ immage
2.Right mouse click on it (control and mouse click)
3. Save Image

Actual Results:  
The down load window pops up

Expected Results:  
Make the pop up window optional for all down loads and get rid of it for saving
images

Comment 1

[Jesse Ruderman]

Might be a dup of bug 66723 (seamonkey), "Download progress window should not
appear when saving from cache".

Comment 2

[Josh Aas]

taking

Comment 3

[Jasper]

I agree it should not display in the dl manager, it should behave just like when
you drag an image to the dekstop. My 2 cents.

Comment 4

[Julian Pellico]

I might take a look at this if you haven't already

Comment 5

[Josh Aas]

I have looked at this, though I don't plan on fixing it myself any time soon. We
just need to do a check to see if what is being saved is coming from the cache
or not. However, a the cache check might be tricky as a download could be cached
(right?). If its not a displayed item like a picture or text, it should always
open the download window.

Last time I discussed this bug there was some concern over whether or not this
was a bug at all. I'm not sure where I stand, but I'd say mimick Safari and
Firefox (assuming they both do the same thing).

Comment 6

[Julian Pellico]

Ugh...this gets too much into the Mozilla code for me to comprehend anyway.

Comment 7

[David Munch]

I say it should pop up regardless of cache. A download is a download, and
there's a reason you are re-downloading it and therefore you'd probably want to
follow the progress. Maybe the first file was corrupt, and stopping at some
point in the download and you want to check when it happens. (Or happens at all)

Comment 8

[Josh Aas]

I am still undecided about this, but in any case its not an 0.9 issue.

Comment 9

[Josh Aas]

looks like a job for the all-powerful-download-master kreeger

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 158751 has been marked as a duplicate of this bug. ***

Comment 11

[Samuel Sidler (old account; do not CC)]

As Josh said, there's the question as to whether this is a bug at all.

On one hand, a download is a download is a download. Showing the download manager should happen whenever something is "downloaded" as opposed to "drag and dropped" from the content view. If it's from cache, does that really matter? You're still "downloading" the content even if, in that instance, it's simply from cache. In addition, should casual users have to figure out why the download manager shows sometimes but not others? It seems complicating for users.

On the other hand, since there isn't something being downloaded (in the literal sense) from the internet, should it be show in the "download" manager?

To successfully do this "bug" (as written), we'd have to say anything in cache (including pages when using File->Save As) shouldn't be shown in the download manager. It's an, overall, messy situation.

As it stands, the following behaviors are seen in various browsers when right clicking and selecting "save image...", or the comparable option:
1. MacIE: Don't show download manager, but put download in it.
2. Safari 2: Don't show download manager, don't put download in it.
3. Firefox 1.5: Show download manager with download in it.
4. Camino: Show download manager with download in it.

As I said above, this is a confusing issue. I'm of the opinion that what we currently do (show the download manager) is correct for the reasons listed above. Smokey disagrees. :)

Retargeting this bug for Future. We need more discussion on what should be done.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

From bug 159201 (context menu for link: change Save Link As to Download Link):

------- Comment #3 From Mike Pinkerton  2002-07-24 15:08 PST  [reply] -------

talked it over with simon, we changed it to "Download Link Target..." and kept
"Save Image" the same because it's local, you don't have to d/l it.

---

Note also that we don't show the dl manager (or add stuff to it) when saving images via drag-and-drop (and I hope no one in his or her right mind will advocate us starting to do that).

I certainly see both sides of the issue, "why does it show sometimes and not others" vs. "it's cached; it doesn't need to be 'downloaded' again", but I fall in the latter camp partly because of the annoyance factor (showing the dl manager all too often, and this operation already shows the save dialogue, too) and partly because that's how browsers behaved when I first started using them....

As Sam says, at least what we're doing right now is consistent, even if it is annoying ;)

Comment 13

[Nick Kreeger]

Would a pref (hidden or nib-ed) help out here?

Comment 14

[Chris Lawson (gone)]

-> 1.2 with the rest of DL manager bugs.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 16

[Chris Lawson (gone)]

We just had a request from feedback for this, and I agree that it's a bug that we show it in this case. The Mac Way™ (see comment 11) has traditionally been not to do this for images.