Open
Bug 2095831
Opened 1 day ago
Updated 1 day ago
Remove the unused homepage stories code from Fenix
Categories
(Firefox for Android :: Stories, task, P3)
Tracking
()
ASSIGNED
People
(Reporter: gl, Assigned: gl)
References
Details
(Whiteboard: [fxdroid] [group5])
Attachments
(2 external files)
Removing the stories section from the homepage (bug 2072025) and the old Pocket stories composables (bug 2003371) left code behind in Fenix that nothing in production calls anymore.
Files to delete (under app/src/main/java/org/mozilla/fenix/):
home/pocket/ui/PocketSection.kt: last caller removed in bug 2072025home/pocket/ui/StoriesCategories.kt: last production caller removed in bug 2003371. Its only remaining caller is theStoriesWithCategoriesPreviewpreview inhome/pocket/ui/Stories.kt, which should go too.compose/LazyListEagerFlingBehavior.kt(eagerFlingBehavior): last caller removed in bug 2003371
Also remove the resources that only these files used, such as the pocket_stories_header_2 and stories_discover_more_content_description strings, and any detekt baseline entries for the deleted files.
Updated•1 day ago
|
| Assignee | ||
Comment 1•1 day ago
|
||
- Delete
PocketSection, last used before bug 2072025 - Delete
StoriesCategoriesandeagerFlingBehavior, last used before bug 2003371 - Remove
StoriesWithCategoriesPreviewand thestories_discover_more_content_descriptionstring
| Assignee | ||
Comment 2•1 day ago
|
||
- Disabled since bug 2075240 because the homepage stories section was removed in bug 2072025
- Remove the
HomeScreenRobotandSettingsSubMenuHomepageRobothelpers only it used - Remove the
pocket_stories_header_2string
You need to log in
before you can comment on or make changes to this bug.
Description
•