Closed Bug 2094946 Opened 2 days ago Closed 1 day ago

Remove the remaining unused toolbar code from Fenix

Categories

(Firefox for Android :: Toolbar, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
163 Branch
Tracking Status
firefox163 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] [group5])

Attachments

(6 external files)

Removing the XML toolbar (bug 2029550) and the toolbar interactor/controller (bug 2036832) left toolbar code behind in Fenix that nothing in production calls anymore. Some of it is still kept alive by unit tests.

Files to delete (under app/src/main/java/org/mozilla/fenix/):

  • components/toolbar/FenixTabCounterMenu.kt and FenixTabCounterMenuTest: last caller removed in bug 2029550
  • utils/ToolbarPopupWindow.kt and its test: last caller removed in bug 2029550
  • utils/ThemeUtils.kt (getAppNightMode) and its test: last caller removed in bug 2029550
  • components/toolbar/ToolbarMenu.kt (ToolbarMenu and its Item sealed class): last caller removed in bug 2036832
  • components/toolbar/BrowserFragmentStore.kt (BrowserFragmentStore, BrowserFragmentState, BrowserFragmentAction): unused since bug 1948751 part 1 stopped creating its ViewModel

Unused declarations in files that are otherwise still used:

  • ACTION_ADD_NEW_TAB_LONG_CLICKED and ACTION_OPEN_IN_FENIX in telemetry/ToolbarTelemetryConstants.kt: last used before bug 2036832
  • View.increaseTapAreaVertically in ext/View.kt: last used before bug 2027031 removed the homepage XML toolbar stub
Assignee: nobody → gl
Status: NEW → ASSIGNED
  • Last caller removed with the XML toolbar in bug 2029550
  • Last caller removed with the XML toolbar in bug 2029550
  • Delete the browser_toolbar_popup_window layout and the drawable, strings and dimens only it used
  • Last caller removed with the XML toolbar in bug 2029550
  • Last consumer of ToolbarMenu.Item removed in bug 2036832
  • Remove ACTION_ADD_NEW_TAB_LONG_CLICKED and ACTION_OPEN_IN_FENIX, last used before bug 2036832
  • Remove View.increaseTapAreaVertically, last used before bug 2027031
Attachment #9686071 - Attachment description: Bug 2094946 - Part 1: Remove the unused `FenixTabCounterMenu`. → Bug 2094946 - Part 1: Remove the unused `FenixTabCounterMenu`
Attachment #9686072 - Attachment description: Bug 2094946 - Part 2: Remove the unused `ToolbarPopupWindow`. → Bug 2094946 - Part 2: Remove the unused `ToolbarPopupWindow`
Attachment #9686073 - Attachment description: Bug 2094946 - Part 3: Remove the unused `getAppNightMode`. → Bug 2094946 - Part 3: Remove the unused `getAppNightMode`
Attachment #9686074 - Attachment description: Bug 2094946 - Part 4: Remove the unused `ToolbarMenu`. → Bug 2094946 - Part 4: Remove the unused `ToolbarMenu`
Attachment #9686075 - Attachment description: Bug 2094946 - Part 5: Remove the unused `BrowserFragmentStore`. → Bug 2094946 - Part 5: Remove the unused `BrowserFragmentStore`
Attachment #9686076 - Attachment description: Bug 2094946 - Part 6: Remove unused toolbar telemetry and tap area helpers. → Bug 2094946 - Part 6: Remove unused toolbar telemetry and tap area helpers
See Also: → 2094955
See Also: → 2094991
See Also: → 2095831
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: