Closed
Bug 2094946
Opened 2 days ago
Closed 1 day ago
Remove the remaining unused toolbar code from Fenix
Categories
(Firefox for Android :: Toolbar, task, P3)
Tracking
()
RESOLVED
FIXED
163 Branch
| Tracking | Status | |
|---|---|---|
| firefox163 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group5])
Attachments
(6 external files)
Removing the XML toolbar (bug 2029550) and the toolbar interactor/controller (bug 2036832) left toolbar code behind in Fenix that nothing in production calls anymore. Some of it is still kept alive by unit tests.
Files to delete (under app/src/main/java/org/mozilla/fenix/):
components/toolbar/FenixTabCounterMenu.ktandFenixTabCounterMenuTest: last caller removed in bug 2029550utils/ToolbarPopupWindow.ktand its test: last caller removed in bug 2029550utils/ThemeUtils.kt(getAppNightMode) and its test: last caller removed in bug 2029550components/toolbar/ToolbarMenu.kt(ToolbarMenuand itsItemsealed class): last caller removed in bug 2036832components/toolbar/BrowserFragmentStore.kt(BrowserFragmentStore,BrowserFragmentState,BrowserFragmentAction): unused since bug 1948751 part 1 stopped creating its ViewModel
Unused declarations in files that are otherwise still used:
ACTION_ADD_NEW_TAB_LONG_CLICKEDandACTION_OPEN_IN_FENIXintelemetry/ToolbarTelemetryConstants.kt: last used before bug 2036832View.increaseTapAreaVerticallyinext/View.kt: last used before bug 2027031 removed the homepage XML toolbar stub
| Assignee | ||
Updated•2 days ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Updated•2 days ago
|
| Assignee | ||
Comment 1•2 days ago
|
||
- Last caller removed with the XML toolbar in bug 2029550
| Assignee | ||
Comment 2•2 days ago
|
||
- Last caller removed with the XML toolbar in bug 2029550
- Delete the
browser_toolbar_popup_windowlayout and the drawable, strings and dimens only it used
| Assignee | ||
Comment 3•2 days ago
|
||
- Last caller removed with the XML toolbar in bug 2029550
| Assignee | ||
Comment 4•2 days ago
|
||
- Last consumer of
ToolbarMenu.Itemremoved in bug 2036832
| Assignee | ||
Comment 5•2 days ago
|
||
- No longer created since bug 1948751
| Assignee | ||
Comment 6•2 days ago
|
||
- Remove
ACTION_ADD_NEW_TAB_LONG_CLICKEDandACTION_OPEN_IN_FENIX, last used before bug 2036832 - Remove
View.increaseTapAreaVertically, last used before bug 2027031
Updated•2 days ago
|
Attachment #9686071 -
Attachment description: Bug 2094946 - Part 1: Remove the unused `FenixTabCounterMenu`. → Bug 2094946 - Part 1: Remove the unused `FenixTabCounterMenu`
Updated•2 days ago
|
Attachment #9686072 -
Attachment description: Bug 2094946 - Part 2: Remove the unused `ToolbarPopupWindow`. → Bug 2094946 - Part 2: Remove the unused `ToolbarPopupWindow`
Updated•2 days ago
|
Attachment #9686073 -
Attachment description: Bug 2094946 - Part 3: Remove the unused `getAppNightMode`. → Bug 2094946 - Part 3: Remove the unused `getAppNightMode`
Updated•2 days ago
|
Attachment #9686074 -
Attachment description: Bug 2094946 - Part 4: Remove the unused `ToolbarMenu`. → Bug 2094946 - Part 4: Remove the unused `ToolbarMenu`
Updated•2 days ago
|
Attachment #9686075 -
Attachment description: Bug 2094946 - Part 5: Remove the unused `BrowserFragmentStore`. → Bug 2094946 - Part 5: Remove the unused `BrowserFragmentStore`
Updated•2 days ago
|
Attachment #9686076 -
Attachment description: Bug 2094946 - Part 6: Remove unused toolbar telemetry and tap area helpers. → Bug 2094946 - Part 6: Remove unused toolbar telemetry and tap area helpers
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2efb97a19209
https://hg.mozilla.org/integration/autoland/rev/609657e8eb5d
Part 1: Remove the unused `FenixTabCounterMenu` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/06fd9cfce6c6
https://hg.mozilla.org/integration/autoland/rev/ea7a658e4ba3
Part 2: Remove the unused `ToolbarPopupWindow` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/5b5cf5fbbc60
https://hg.mozilla.org/integration/autoland/rev/f53e0e537287
Part 3: Remove the unused `getAppNightMode` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/0496302a76a2
https://hg.mozilla.org/integration/autoland/rev/ffadb428c1be
Part 4: Remove the unused `ToolbarMenu` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/76aada77bacf
https://hg.mozilla.org/integration/autoland/rev/db3f818bffff
Part 5: Remove the unused `BrowserFragmentStore` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/2bc5cbe26a3a
https://hg.mozilla.org/integration/autoland/rev/947210b5f2f9
Part 6: Remove unused toolbar telemetry and tap area helpers r=android-reviewers,petru
Comment 8•1 day ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/609657e8eb5d
https://hg.mozilla.org/mozilla-central/rev/ea7a658e4ba3
https://hg.mozilla.org/mozilla-central/rev/f53e0e537287
https://hg.mozilla.org/mozilla-central/rev/ffadb428c1be
https://hg.mozilla.org/mozilla-central/rev/db3f818bffff
https://hg.mozilla.org/mozilla-central/rev/947210b5f2f9
Status: ASSIGNED → RESOLVED
Closed: 1 day ago
status-firefox163:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 163 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•