210094 - [FIX]Specifying min-height on fieldset tag has no effect.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[mcknzm]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030612
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030612

When using min-height with fieldset tag, it has no effect. But when using
min-height with div, it works as expected.

Reproducible: Always

Steps to Reproduce:
1. Create a html file with this code in it:
------
<fieldset style="min-height: 200px; border: 1px solid black;">
<legend>min-height test</legend>
<p>Test content.</p>
</fieldset>

<div style="min-height: 200px; border: 1px solid black;">
<p>Test content.</p>
</div>
------

2. Open created html file with Mozilla.
Actual Results:  
Fieldset block's height is not 200px. Div block's height is 200px.

Expected Results:  
Fieldset block's height should have been 200px.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For now, this is a form controls bug, although it might be nice to refactor code
so the necessary code doesn't need to be copied all over the place.

Comment 2

[Bill Mason]

Attachment: testcase

Testcase along the lines of the code in the bug report.  Works as expected in
Opera 7.

Comment 3

[Bill Mason]

Confirm new, added kw testcase

Comment 4

[Boris Zbarsky [:bzbarsky]]

This could probably be fixed by adding inherit for min-height and max-height to
the *|*:-moz-fieldset-content rule in forms.css....

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

...not unless we implement a different meaning of 'inherit', which we may for
CSS2.1.

Comment 6

[Robin Whittleton]

It doesn't look like 'inherit' changed to the extent that bz's proposed fix
would work.

http://www.w3.org/TR/CSS2/cascade.html#value-def-inherit
http://www.w3.org/TR/CSS21/cascade.html#value-def-inherit

Having said that, I'm not sure what the problem with the original meaning was.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> It doesn't look like 'inherit' changed 

The text describing 'inherit' did not change, but the definition of "computed
value" did, actually.

That said, my proposal won't work because the computed value for percent heights
is the percentage, so "min-height: 50%" won't work right if we just use inherit.

Comment 8

[Arnau Siches]

no effect in Mac OS X 10.4.2 and no effect in Windows XP

Comment 9

[Bohdan Ganický]

I've just come upon this bug as of June 2007. Min-height on fieldset still doesn't work. Is this bug going to be resolved anytime soon? Now I use javascript to make it work.

Thanks.

Comment 10

[David Foster]

February 2007 and is still not fixed. I've fallen victim to this bug a few times now.

Comment 11

[Atanas Barotov]

End of May 2008 - still not fixed. Hope FF3 got it right..

Comment 12

[Boris Zbarsky [:bzbarsky]]

Please stop with the "not fixed" comments.  It's obviously not fixed: the bug is still open.  It won't be fixed in Firefox 3 (which is in code freeze and has been for a while).  Sending out spam mail to everyone cced on the bug every so often won't get this fixed faster.

It's on my (long) list of things to fix, but to be honest it's a lower priority than a lot of them.  If you think it needs to happen faster, I'm happy to point you at the relevant code and so forth.  Please mail me if you want to work on this.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: This should do it

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 331388 [details] [diff] [review]
This should do it

r+sr=dbaron, if you also add a != test comparing the reference to a reference with a different height, to ensure that fieldsets have something that makes their height visible.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Added such a test, and pushed changeset 8603d5d17077.