21061 - Customize panel button does not work

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[fornixon]

Overview Description:
The Customize Panel button in the Customize Sidebar dialog box doesn't allow for
customization of content

Steps to Reproduce:
1)start mozilla
2)click the customize button on the sidebar
3)add the weather panel
4)select weather from the right-hand list
5)click the Customize Panel... buttton

Actual Results:
The Customize Panel.. and Remove buttons get bigger, and the left-side list
and the dialog window get taller, and that's it.

Expected Results:
Button should lead to some sort of Netcenter page to allow content to be
customized. ie choose cities for weather, ticker symbols for stocks, etc.

Build Date & Platform Bug Found:
Build ID 1999120608, Win98

Additional Builds and Platforms Tested On:
none

Additional Information:
none

Comment 1

[Cyril Bortolato]

Attachment: Here's a patch

Comment 2

[Cyril Bortolato]

The Customize Panel button now works. But the window that pops up is empty
for the few panels I tried. Also, these panels have no title attributes
available (turn on the debug function in customize.js and see the title/url
messages).

Hope this helps,
Cyril

Comment 3

[Cyril Bortolato]

Attachment: 2nd patch to correct GUI problems

Comment 4

[Cyril Bortolato]

What this 2nd patch does:
- When the Customize Panel button is clicked, Customize Panel and Remove buttons
  don't grow bigger, and left-side list does not grow taller.
- The window can be resized correctly. The 2 lists will then grow larger,
  showing more items. Buttons will keep their sizes.

This is done by adding a flex to the main horizontal box, and by removing
the flex of the box around Customize Panel and Remove buttons.

Cyril

Comment 5

[johng]

*** Bug 21865 has been marked as a duplicate of this bug. ***

Comment 6

[Brad Nixon]

[e-mail] is now [e-mail]. CC'ing the new address to
ensure I am notified of all changes to this bug.

Comment 7

[Paul MacQuiddy]

slamm, this is marked m16, it should be in for beta, right? there are two
problems here, the button problem, and the customize button problem

Comment 8

[Steve Lamm]

Thank you for the patch. I changed it a little. Instead of bringing up the
customize dialogs, it loads the customize dialog in a chromeless window. It will
be up to the panel provider to provide a customize UI.

Comment 9

[Cyril Bortolato]

In function CustomizePanel() in customize.js line 231, 'selected-panels'
should be replaced by 'current-panels'. That's the name of the right tree
control containing user's selections.

Cyril

Comment 10

[Paul MacQuiddy]

This is not working, re-opening. I'm getting a JS error in customize.js, line
232. I think this is what borto is referring to.

To reproduce:
1. Open Sidebar, launch customize dialogue
2. Select My News under Panels currently in Sidebar
3. Select Customize Panel (which becomes active after selecting My News)

Results: Nothing but JS error in console
Expected: Chromeless window

Using Linux 1/11 build

Comment 11

[Paul MacQuiddy]

okay, this is fixed now

Comment 12

[Paul MacQuiddy]

verified with 1/19 builds