211276 - nsStaticCaseInsensitiveNameTable::Init doesn't check the return value of PL_DHashTableInit

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 131     mNameArray = (nsDependentCString*)nsMemory::Alloc(Count * sizeof
(nsDependentCString));
 132     PL_DHashTableInit(&mNameTable, &nametable_CaseInsensitiveHashTableOps,
 133                       nsnull, sizeof(nameTableEntry), Count);
 134     if (!mNameArray || !mNameTable.ops) {
 135         return PR_FALSE;
 136     }

Comment 1

[timeless]

Attachment: proposed patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 126835 [details] [diff] [review]
proposed patch

If you're going to bother writing the code to handle out-of-memory here, you
should fix the destructor as well.

Comment 3

[timeless]

Attachment: -uwp11, 4 space indentation, fixes destructor

Comment 4

[Alec Flett]

Comment on attachment 127031 [details] [diff] [review]
-uwp11, 4 space indentation, fixes destructor

r=alecf

Comment 5

[timeless]

checked in

Comment 6

[timeless]

checked in