211260 - Crash [@ SearchTable] - OOM (probably failed + unchecked call to PL_DHashTableInit)

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect, P5)

Description

[timeless]

Stack Signature     SearchTable dca7047a
Product ID      Gecko1.4
Build ID        2003062408
Trigger Time    2003-06-30 23:48:41
Platform        Win32
Operating System        Windows NT 5.0 build 2195
Module  xpcom.dll

SearchTable [d:/builds/seamonkey/mozilla/xpcom/ds/pldhash.c, line 350]

dbradley wrote:
Talkback is only reporting the single function.
it failed on mov eax, [esi] because esi was 0xe28
After that, it did a test of eax

The guess is that entryStore was 0

Unfortunately there are lots of pldhash users.

My bet is that one of the many PL_DHashTableInit consumers didn't check the 
return value. Because of this, I'm going to treat this as a meta bug and file 
bugs for all of the broken consumers although I think that I can narrow down 
the field of ones likely to have actually caused this crash.

Comment 1

[Mike Pesce (:By-Tor)]

I'm assuming this is the same bug.
TB17820181E
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060421 Minefield/3.0a1 ID:2006042114

Comment 2

[timeless]

i think it's fairly safe it say it isn't the same bug. this is an oom thing, yours is a shutdown problem possibly caused by something being left half destroyed or already destroyed....

Comment 4

[Robert Kaiser]

https://crash-stats.mozilla.com/report/list?signature=SearchTable still lists quite a few crashes, but no idea if they are the same issue or not. Is this a bug we should close or should we keep it open to track those?

Comment 5

[Andrew McCreight [:mccr8]]

I made PL_DHashtableInit infallible in bug 962608, and audited every call to it at that time.