211277 - nsPersistentProperties::nsPersistentProperties doesn't check the return value of PL_DHashTableInit

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 120 nsPersistentProperties::nsPersistentProperties()
 121 {
 122   mIn = nsnull;
 123   mSubclass = NS_STATIC_CAST(nsIPersistentProperties*, this);
 124   PL_DHashTableInit(&mTable, &property_HashTableOps, nsnull,
 125                     sizeof(propertyTableEntry), 20);
 126
 127   PL_INIT_ARENA_POOL(&mArena, "PersistentPropertyArena", 2048);
 128
 129 }

 137 NS_METHOD
 138 nsPersistentProperties::Create(nsISupports *aOuter, REFNSIID aIID, void 
**aResult)
 139 {
 140     if (aOuter)
 141         return NS_ERROR_NO_AGGREGATION;
 142     nsPersistentProperties* props = new nsPersistentProperties();
 143     if (props == nsnull)
 144         return NS_ERROR_OUT_OF_MEMORY;

Comment 1

[timeless]

Attachment: proposed fix

this also includes a warning fix from rev 1.33 which alecf rolled back in 1.38.
it's past 1.4 and i'd like to kill the warning :)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 126837 [details] [diff] [review]
proposed fix

It's rather unusual to do this type of thing in a factory function.  Could you
create an Init method instead?	(It could be inline if you want.)

Comment 3

[timeless]

Attachment: w/ init method

Comment 4

[Alec Flett]

Comment on attachment 127057 [details] [diff] [review]
w/ init method

sr=alecf

Comment 5

[timeless]

checked in

Comment 6

[timeless]

checked in