211292 - nsNSSShutDownList::nsNSSShutDownList doesn't check the return value of PL_DHashTableInit

Status: RESOLVED DUPLICATE of bug 962608

(Core Graveyard :: Security: UI, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

  90   mPK11LogoutCancelObjects.ops = nsnull;
  91   mObjects.ops = nsnull;
  92   PL_DHashTableInit(&mObjects, &gSetOps, nsnull,
  93                     sizeof(ObjectHashEntry), 16);
  94   PL_DHashTableInit(&mPK11LogoutCancelObjects, &gSetOps, nsnull,
  95                     sizeof(ObjectHashEntry), 16);
  96 }
  97
  98 nsNSSShutDownList::~nsNSSShutDownList()
  99 {
 100   if (mListLock) {
 101     PR_DestroyLock(mListLock);
 102     mListLock = nsnull;
 103   }
 104   if (mObjects.ops) {
 105     PL_DHashTableFinish(&mObjects);
 106     mObjects.ops = nsnull;
 107   }
 108   if (mPK11LogoutCancelObjects.ops) {
 109     PL_DHashTableFinish(&mPK11LogoutCancelObjects);
 110     mPK11LogoutCancelObjects.ops = nsnull;
 111   }

Comment 1

[timeless]

Attachment: patch

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 128532 [details] [diff] [review]
patch

Your change makes sense, but I suggest to be complete. 

The change you made in one of the ::remember methods should probably be made in
both ::remember and in both ::forget functions.

Comment 3

[John G. Myers]

Timeless, could you update the patch?

Comment 4

[John G. Myers]

Mass reassign ssaux bugs to nobody

Comment 5

[Andrew McCreight [:mccr8]]

Init is infallible now.