211788 - GTK - Universal prompt should invert buttons order

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Marco Pesenti Gritti]

Unlike other dialogs the universal one show the buttons in left to right order.
The GNOME HIG require the buttons to be showed right to left.
To reproduce try to login in bugzilla with a random user name, the passoword
storing confirmation dialog will be showed.
Order is Yes, No, Never, but it should be Never, No, Yes.

Comment 1

[Marco Pesenti Gritti]

Attachment: Invert the order and set default response to 0 (gtk by default would use the first added button)

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 127084 [details] [diff] [review]
Invert the order and set default response to 0 (gtk by default would use the first added button)

sr=blizzard

Comment 3

[André Dahlqvist]

Hmm, aren't there a lot of other dialogs that use the non-HIG ordering of
buttons? I must be misunderstanding something here. Bug 110647 also requests
that Mozilla should follow GNOME's HIG in this regard, giving a random example
of a dialog that doesn't follow it.

Comment 4

[André Dahlqvist]

Ahaa, embedding. Ignore me.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 127084 [details] [diff] [review]
Invert the order and set default response to 0 (gtk by default would use the first added button)

The reason I didn't do this is because we can't really make any assumptions
about the function of the buttons in this method.  The HIG gives the button
positions by function, i.e. the confirmation button in the lower right, cancel
to the left of it.

However, I don't think this hurts anything and it seems to be the right thing
for most/all of our dialogs, so r=bryner.

Comment 6

[Marco Pesenti Gritti]

Can someone commit this ? It has s/sr but I dont have cvs access. Thanks.

Comment 7

[Marco Pesenti Gritti]

Comment on attachment 127084 [details] [diff] [review]
Invert the order and set default response to 0 (gtk by default would use the first added button)

While this is not a critical issue the patch is simple enough to not be risky.
The impact is also limited (only gtkmozembed users). HIG compliance is very
important for GNOME applications like epiphany and galeon.
I'm requesting approval also for 1.4.x because Epiphany (GNOME 2.4 browser)
will be based on that.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 127084 [details] [diff] [review]
Invert the order and set default response to 0 (gtk by default would use the first added button)

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta. Will wait to
evaluate for 1.4.1 until it proves itself on the trunk.

Comment 9

[timeless]

checked into trunk

Comment 10

[Marco Pesenti Gritti]

Verified the checkin. Leaving this open until I got approval for 1.4.x

Comment 11

[Asa Dotzler [:asa]]

please resolve fixed bugs when they're fixed on the trunk. until a bug is
resolved and verified on the trunk, it's not going to be seriously evaluated as
a potential branch fix.

Comment 12

[Marco Pesenti Gritti]

Fixed on trunk

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 127084 [details] [diff] [review]
Invert the order and set default response to 0 (gtk by default would use the first added button)

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2.