211894 - "Show File Location" starts (launches) an executable of the same name (in nsILocalFile::Reveal)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jan Rieke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

When clicking "Show File Location" on a file thats downloaded to X:\test\, a
file X:\test.exe is executed instead of showing the explorer window of X:\test\.

Possible fix:
Replace
"LONG r = (LONG) ::ShellExecute( NULL, "open", path.get(), NULL, NULL,
SW_SHOWNORMAL);"
by
"LONG r = (LONG) ::ShellExecute( NULL, "explore", path.get(), NULL, NULL,
SW_SHOWNORMAL);"

Reproducible: Always

Steps to Reproduce:
1. Download a file into a folder named "X:\test\"  with a file "X:\test.exe"
existing
2. Click on "Show File Location"

Actual Results:  
X:\text.exe is executed.


Expected Results:  
Show the explorer window of "X:\test\"

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like a bug in nsLocalFileWin::Launch()

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

In ::Reveal actually

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

btw... for some reason the fix in comment 0 isn't working. if I change that to
"explore", ShellExecute returns 31.

Comment 4

[Jan Rieke]

Well, that was a suggestion, i did not test it. :)

31 is SE_ERR_NOASSOC: "There is no application associated with the given
filename extension."

Comment 5

[:deanis74]

Maybe it's time to re-visit my patch for bug 156422.  Reading through that,
you'll find that it's basically the same as what Windows does when you select
'Explore' from a folder's context menu.

Comment 6

[[e-mail]]

The issue is that LONG r = (LONG) ::ShellExecute( NULL, "open", path.get(),
NULL, NULL, SW_SHOWNORMAL); is insecure and needs Dean's patch to fix it.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 239640 has been marked as a duplicate of this bug. ***

Comment 8

[Andreas Kunz]

Bug 156422 was checked in and also did fix this bug. I just verified with cvs
builds from before and after the fix. Any reason for not resolving this bug here?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

marking so

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 283008 has been marked as a duplicate of this bug. ***

Comment 11

[Daniel Veditz [:dveditz]]

*** Bug 290280 has been marked as a duplicate of this bug. ***