212095 - checksetup.pl requires downgrade of DBD::mysql to 2.1026 (reports 'fielddefs' or 'tokens' already exists)

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Jonathan Locke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

While upgrading from 2.14.1 to 2.16.3, I ran into a problem with checksetup.pl.
 I got "Table 'fielddefs' already exists at ./checksetup.pl line 1636".  I
talked to bbaetz @ acm . org about the problem.  He asked to be cc-ed but I
don't see how to do that in the new bug interface here.  Apparently the problem
stems from the latest version of DBD::mysql putting backquotes around all the
table names.  My tables (when uncommenting the table-printing debug code at line
1614 in checksetup.pl) looked like this:  	

Tables: `attachments` `bugs` `bugs_activity` `cc` `components` `dependencies`
`duplicates` `fielddefs` `groups` `keyworddefs` `keywords` `logincookies`
`longdescs` `milestones` `namedqueries` `products` `profiles`
`profiles_activity` `shadowlog` `tokens` `versions` `votes` `watch`

Downgrading to 2.1026 fixed this problem and allowed me to proceed.

Reproducible: Always

Steps to Reproduce:
1. Install latest bugzilla
2. Install Bundle::Bugzilla to get latest DBD::mysql (2.9002)
3. Attempt to upgrade old database using checksetup.pl
Actual Results:  
DBD::mysql::db do failed: Table 'fielddefs' already exists at ./checksetup.pl
line 1636.

Expected Results:  
Fixed up my old schema, I hope... ;-)

Comment 1

[Bradley Baetz (:bbaetz)]

As confirmed this morning on IRC, the new DBD::mysql version is quoting the
returned names, which breaks our grep. We probably want to use table_info instead.

Comment 2

[Dave Miller [:justdave]]

*** Bug 211973 has been marked as a duplicate of this bug. ***

Comment 3

[Bradley Baetz (:bbaetz)]

-> me

Comment 4

[Bradley Baetz (:bbaetz)]

Attachment: fix for 2.17.4

DBI quotes teh results of ->tables if the DBD driver procives quote_identifier,
which the newer version does.

Use table_info instead, and we can definativly just get the table, so don't
need the bogus regexp to split off the schema (aka db in mysql-speak)

Comment 5

[Oscar Manuel Gómez Senovilla]

The patch works for me, but I can't mark the bug as resolved.

Comment 6

[Bradley Baetz (:bbaetz)]

*** Bug 212731 has been marked as a duplicate of this bug. ***

Comment 7

[Jouni Heikniemi]

Comment on attachment 127526 [details] [diff] [review]
fix for 2.17.4

Ouch, just bumped my head into this.
To me, the patch looks right and works --> r=jouni (it's been a while since the
last one!). You may still want Myk's review in case you need a DBD/mysql
specialist's look - I couldn't swear that Columns[3] works right in every
configuration ;-)

Comment 8

[Bradley Baetz (:bbaetz)]

Fixed.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 127526 [details] [diff] [review]
fix for 2.17.4

removing unneeded review request

Comment 10

[Dave Miller [:justdave]]

*** Bug 215538 has been marked as a duplicate of this bug. ***

Comment 11

[Dave Miller [:justdave]]

This is a showstopper for installation, we need to fix this for 2.16.5, too.

Comment 12

[Dave Miller [:justdave]]

This patch applies unmodified to the 2.16 branch. :)

checked in.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.149.2.17; previous revision: 1.149.2.16
done

Comment 13

[Dave Miller [:justdave]]

Attachment: fix for 2.16.3

OK, turns out there was a conflict with where $sth was declared between the two
versions.  Here's the final patch that actually went into the 2.16 branch.

Comment 14

[Dave Miller [:justdave]]

fixing version number, I'm getting ahead of myself. :)

Comment 15

[Christian Reis]

Comment on attachment 129481 [details] [diff] [review]
fix for 2.16.3

I've tested (on a CVS version based on the 2.16 branch) and it works fine.

Comment 16

[Dave Miller [:justdave]]

granting approval posthumously since this has already been checked in (I must
have missed it when I did the checkin.

Comment 17

[Jouni Heikniemi]

*** Bug 219607 has been marked as a duplicate of this bug. ***

Comment 18

[chaduv]

*** Bug 219618 has been marked as a duplicate of this bug. ***

Comment 19

[chaduv]

*** Bug 215711 has been marked as a duplicate of this bug. ***

Comment 20

[Christopher Wong]

Attachment: Output of "fixed" checksetup.pl (version 2.16.4)

Comment 21

[Christopher Wong]

This fix breaks earlier versions of DBD::mysql. I am using perl-DBD-MySQL-1.
2216-4.i386.rpm from Red Hat 7.2, and checksetup.pl now blows up with "DBI 
table_info: invalid number of parameters: handle + 4". I've created an 
attachment:

http://bugzilla.mozilla.org/attachment.cgi?id=134845&action=view

(I should have included this comment when I created the attachment ... sorry).

Comment 22

[Bradley Baetz (:bbaetz)]

Whats hte version number in the .pm file for mysql? What DBI version?

Please commentin a new bug, and cc me

Comment 23

[Jouni Heikniemi]

The followup is bug 224815.