213461 - Want a way to specify single-sided or double-sided printing

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, enhancement)

Description

[Simon Montagu :smontagu]

Currently Xprint gives me no way to specify single-sided or double-sided
printing, and always defaults to double-sided, flipping on the short edge, which
is the last thing I want.

I would like to be able to choose single-sided or double-sided, and flip on
short edge or long edge, in the Printer Properties dialog.

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Attachment: Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

Comment 3

[Roland Mainz]

Comment on attachment 128297 [details] [diff] [review]
Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

Requesting r=/sr= ...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 128297 [details] [diff] [review]
Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

It's going to take me a few days to get to this.

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 128297 [details] [diff] [review]
Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

>Index: gfx/src/gtk/nsDeviceContextSpecG.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/gfx/src/gtk/nsDeviceContextSpecG.cpp,v
>retrieving revision 1.54
>diff -u -r1.54 nsDeviceContextSpecG.cpp
>--- gfx/src/gtk/nsDeviceContextSpecG.cpp	17 Apr 2003 20:16:56 -0000	1.54
>+++ gfx/src/gtk/nsDeviceContextSpecG.cpp	23 Jul 2003 02:34:55 -0000
>@@ -108,21 +108,35 @@
>   nsPrinterFeatures( const char *printername );
>   ~nsPrinterFeatures() {};
> 
>-  /* Does this device allow to set/change the paper size ? */
>+  /* Does this printer allow to set/change the paper size ? */

Why the change from device to printer? Is a "printer" always a printer? Could
it, for example, be a plotter?

>+  /* Does this Mozilla print module allow set/change the paper size ? */
>+  void SetSupportsOrientationChange( PRBool aSupportsOrientationChange );

>+  /* Does this Mozilla print module allow set/change the paper size ? */
>+  void SetSupportsPlexChange( PRBool aSupportsPlexChange );

Looks like you have copied and pasted the comment without modifying it :-)

Same thing below in gfx/src/xlib/nsDeviceContextSpecXlib.cpp

With these nits, r=smontagu on the *.cpp parts of the patch. You will need
someone else for *.js, *.xul, etc.

Comment 6

[Roland Mainz]

Comment on attachment 128297 [details] [diff] [review]
Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

Requesting r= from [e-mail] for the XUL/JS changes in the print job
options dialog...

Comment 7

[Roland Mainz]

*** Bug 207520 has been marked as a duplicate of this bug. ***

Comment 8

[Jessica Blanco]

+    // spooler command
     if (gPrefs.getBoolPref("print.tmp.printerfeatures." +
gPrintSettings.printerName + ".can_change_spoolercommand"))
-      dialog.cmdInput.removeAttribute("disabled");
+      dialog.cmdLabel.removeAttribute("disabled");
     else
-      dialog.cmdInput.setAttribute("disabled","true");
+      dialog.cmdLabel.setAttribute("disabled","true");

Why did you change this to cmdLabel? With this change, the label "Print Command"
is now disabled/enabled instead of the actual text field.


+  var plexNames = ["default"];
...
+              label = gStringBundle.GetStringFromName(plexObj.name)
Are you going to localize "default" in printPageSetup.properties?

To make the properties dialog a little prettier and align all the colons, you
can add the following to printjoboptions.xul -
+       <hbox align="center" pack="end">
          <label value="&colorGroup.label;"/>
+       </hbox>

Comment 9

[Roland Mainz]

Attachment: Patch to fix all issues listed in previous comments

Comment 11

[Roland Mainz]

Jessica Blanco wrote:
> +    // spooler command
>      if (gPrefs.getBoolPref("print.tmp.printerfeatures." +
> gPrintSettings.printerName + ".can_change_spoolercommand"))
> -      dialog.cmdInput.removeAttribute("disabled");
> +      dialog.cmdLabel.removeAttribute("disabled");
>      else
> -      dialog.cmdInput.setAttribute("disabled","true");
> +      dialog.cmdLabel.setAttribute("disabled","true");
> 
> Why did you change this to cmdLabel? With this change, the label "Print
Command"
> is now disabled/enabled instead of the actual text field.

Erm... likely a mistake...
... FIXED.

> +  var plexNames = ["default"];
> ...
> +              label = gStringBundle.GetStringFromName(plexObj.name)
> Are you going to localize "default" in printPageSetup.properties?

Not yet, this path is for the PostScript module which does not implement plex
mode selection yet. I've added some infrastructure that people can "hook" for
stuff later in here - "default" is therefore a dummy entry to make the
codesyntactically correct :)

> To make the properties dialog a little prettier and align all the colons, you
> can add the following to printjoboptions.xul -
> +       <hbox align="center" pack="end">
>           <label value="&colorGroup.label;"/>
> +       </hbox>

FIXED.

Comment 12

[Roland Mainz]

Comment on attachment 128748 [details] [diff] [review]
Patch to fix all issues listed in previous comments

Moving sr= request over to someone with a less filled-up queue
([e-mail]) ...

Comment 13

[Brian Ryner (not reading)]

Comment on attachment 128748 [details] [diff] [review]
Patch to fix all issues listed in previous comments

>Index: gfx/src/gtk/nsDeviceContextSpecG.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/gfx/src/gtk/nsDeviceContextSpecG.cpp,v
>retrieving revision 1.54
>diff -u -r1.54 nsDeviceContextSpecG.cpp
>--- gfx/src/gtk/nsDeviceContextSpecG.cpp	17 Apr 2003 20:16:56 -0000	1.54
>+++ gfx/src/gtk/nsDeviceContextSpecG.cpp	28 Jul 2003 23:44:59 -0000
>@@ -258,7 +307,7 @@
> #endif
> 
> /** -------------------------------------------------------
>- *  Initialize the nsDeviceContextSpecGTK
>+ *  Initialize the nsDeviceContextSpecXlib
>  *  @update   dc 2/15/98
>  *  @update   syd 3/2/99
>  *

Fix this (copy/paste error) and sr=bryner.

Comment 14

[Matthias Versen [:Matti]]

Comment on attachment 128297 [details] [diff] [review]
Patch for 2003-07-09-08-trunk_cvs to add "plex" section support to the print job options dialog (incl. minor cleanup)

removing obsolete review requests

Comment 15

[Roland Mainz]

Patch checked-in by timeless
(http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&branch=HEAD&cvsroot=/cvsroot&date=explicit&mindate=1059702643&maxdate=1059703200&who=timeless%25mozdev.org)
...

... marking bug as FIXED.

Comment 16

[Mårten Svantesson]

I have now verified that the bug is fixed. But there is one problem with the
fix: wording. I have no problem understanding it, but I don't think everyone
understands the the current wording in the dialog. Here is my proposal:

Plex mode -> Double sided printing
duplex -> On, Flip on Long Edge
simplex -> Off
tumble -> On, Flip on Short Edge