21354 - outlines not drawn for elements with their own views

Status: VERIFIED DUPLICATE of bug 6647

(Core :: Layout, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  Outlines are not drawn for elements with their own views, since
the outlines extend outside of the view (or something like that).

STEPS TO
REPRODUCE:
 * load attached test case

ACTUAL RESULTS:
 * there is a green border, but no red dashed outline outside it

EXPECTED RESULTS:
 * a green border with a red dashed outline immediately outside it

DOES NOT
WORK CORRECTLY ON:
 * Linux, apprunner, 1999-12-09-15-M12

ADDITIONAL INFORMATION:
See also bug 9809 == bug 16301 == bug 18579 and bug 9816.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase described in bug

Comment 2

[Patrick C. Beard]

How can I fix this?

Comment 3

[troy]

I guess you'll have to call the frame and tell it to render its outline.

Re-assigning to Rod, because [I think] he did the outline work.

Comment 4

[rods (gone)]

I did the outline work as more of an experiement and would be more than happy to
remove it. This is absolutely a view issue. We have talked about this in past,
that there is a fundimental problem that since outline draws on the outside of
the frame they need to be sized correctly to take this into account.

Back to you Patrick.

Comment 5

[rods (gone)]

Troy,
Patrick and I discussed this and it is either a frame issue or a style issue.
All I did with outlines was "hook them up". Outline draws on the outside of a
frame, so the frame either needs to adjust clicpping or it needs to (as Patrick
has suggsted) create a "supper-view" that includes extra space for the outline
and then the view itself. Tro, I am assigning this to youbecause it appears to
be a basic issue with the style property "outline" and what exactly any frame
should do with it.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that there are two separate problems with outlines being outside of frames:
 * When outline size is reduced dynamically, the outline isn't properly erased
   because the area redrawn only includes the new outline-width.  This is the
   bugs mentioned in ADDITIONAL INFORMATION above.  The easiest (although
   probably not a good) way to fix this would be to cache the old value of the
   outline-width for every frame, or something like that.
 * When an outline is put on an element with its own view, it doesn't appear at
   all.  That's *this bug*.  I don't understand views all that well, but this
   might be the easier of the two to fix...

Comment 7

[troy]

Since I could care less whether we support outlines for version 1.0 and we don't
seem to have anyone to drive this issue marking it LATER

Comment 8

[Chris Petersen]

Marking verified later per last comments.

Comment 9

[Christopher Hoess (gone)]

LATER is deprecated per bug 35839.

Comment 10

[Christopher Hoess (gone)]

->Style System

Comment 11

[Greg K.]

Reconfirmed using FizzillaCFM/2002071208. Setting All/All.

Why isn't this a duplicate of or at least dependent on bug 6647?

Comment 12

[Boris Zbarsky [:bzbarsky]]

roc, is this yours?

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

*** This bug has been marked as a duplicate of 6647 ***

Comment 14

[Simon Paquet [:sipaq]]

verified duplicate