214172 - Crash in typeFromExtEquals

Status: VERIFIED DUPLICATE of bug 214173

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

missing null check in typeFromExtEquals:
strcmp() line 77
typeFromExtEquals(const char * 0x0012f73c, const char * 0x0012f964) line 319 +
13 bytes
nsOSHelperAppService::GetMIMEInfoFromOS(const char * 0x0012f964, const char *
0x0012f73c) line 441 + 29 bytes
nsExternalHelperAppService::GetFromTypeAndExtension(nsExternalHelperAppService *
const 0x00fa5324, const char * 0x0012f964, const char * 0x0012f73c, nsIMIMEInfo
* * 0x0012f724) line 2103 + 27 bytes
nsExternalHelperAppService::DoContent(nsExternalHelperAppService * const
0x00fa5318, const char * 0x0012f964, nsIRequest * 0x03e4cff8, nsISupports *
0x03b847c8, nsIStreamListener * * 0x0012f92c) line 337 + 57 bytes
nsDocumentOpenInfo::DispatchContent(nsIRequest * 0x03e4cff8, nsISupports *
0x00000000) line 437 + 97 bytes
nsDocumentOpenInfo::OnStartRequest(nsDocumentOpenInfo * const 0x03c9a9a0,
nsIRequest * 0x03e4cff8, nsISupports * 0x00000000) line 227 + 16 bytes
nsHttpChannel::CallOnStartRequest() line 620 + 60 bytes
nsHttpChannel::ProcessNormal() line 747 + 8 bytes
nsHttpChannel::ProcessResponse() line 647 + 8 bytes
nsHttpChannel::OnStartRequest(nsHttpChannel * const 0x03e4d000, nsIRequest *
0x03c885a0, nsISupports * 0x00000000) line 3169 + 11 bytes
nsInputStreamPump::OnStateStart() line 362 + 42 bytes
nsInputStreamPump::OnInputStreamReady(nsInputStreamPump * const 0x03c885a4,
nsIAsyncInputStream * 0x03e03f7c) line 318 + 11 bytes
nsInputStreamReadyEvent::EventHandler(PLEvent * 0x03e94b54) line 117
PL_HandleEvent(PLEvent * 0x03e94b54) line 671 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00ed8348) line 606 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00030144, unsigned int 0x0000c0d9, unsigned int
0x00000000, long 0x00ed8348) line 1412 + 9 bytes
USER32! GetSysColor + 1092 bytes
USER32! GetSysColor + 1377 bytes
USER32! DispatchMessageW + 11 bytes
nsAppShellService::Run(nsAppShellService * const 0x0158c800) line 478
main1(int 0x00000003, char * * 0x00262638, nsISupports * 0x00f5add0) line 1290 +
32 bytes
main(int 0x00000003, char * * 0x00262638) line 1669 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! DosDateTimeToFileTime + 3172 bytes

     LPBYTE pBytes = GetValueBytes( hKey, "Content Type");
     PRBool eq = strcmp((const char *)pBytes, aType) == 0; <-- this crashes if
pBytes is null

might be related to bug 213985

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

I blame bugzilla slowness...

*** This bug has been marked as a duplicate of 214173 ***

Comment 2

[Stephen Walker]

vrfy