Closed Bug 214552 Opened 22 years ago Closed 21 years ago

warning: unused variable `nsresult rv' In member function `virtual nsresult nsMenuItemX::DoCommand()'

Categories

(Core Graveyard :: GFX: Mac, defect)

PowerPC
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(2 obsolete files)

/Users/timeless/mozilla/widget/src/cocoa/nsMenuItemX.cpp: In member function `virtual nsresult nsMenuItemX::DoCommand()': /Users/timeless/mozilla/widget/src/cocoa/nsMenuItemX.cpp:257: warning: unused variable `nsresult rv'
This diff which is small enough to apply by hand fixes the warning Index: widget/src/cocoa/nsMenuItemX.cpp =================================================================== RCS file: /cvsroot/mozilla/widget/src/cocoa/nsMenuItemX.cpp,v retrieving revision 1.10 diff -r1.10 nsMenuItemX.cpp 285c285,286 < return nsEventStatus_eConsumeNoDefault; --- > rv = nsEventStatus_eConsumeNoDefault; > return rv; but I am not sure that the comment about the return from this function is quite accurate.
Attachment #130555 - Flags: review?(mozeditor)
Attachment #130555 - Flags: superreview?(tor)
Attachment #130555 - Flags: review?(mozeditor) → review+
Attachment #130555 - Flags: superreview?(tor) → superreview?(roc)
Attachment #130555 - Flags: superreview?(roc) → superreview+
Comment on attachment 130555 [details] [diff] [review] (Av1) |rv| removal [Checked in: Comment 6] 'approval1.6=?': Trivial unused code removal. (if not too late)
Attachment #130555 - Flags: approval1.6?
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 130555 [details] [diff] [review] (Av1) |rv| removal [Checked in: Comment 6] Too late in the 1.6 timeframe for changes that aren't serious regressions, security, or crash related.
Attachment #130555 - Flags: approval1.6? → approval1.6-
timeless (or anyone): Can you check in your r+&sr+ patch ? Thanks.
Comment on attachment 130555 [details] [diff] [review] (Av1) |rv| removal [Checked in: Comment 6] Check in: { 12/20/2003 20:27 timeless%mozdev.org 1.12 }
Attachment #130555 - Attachment description: the patch i want to use → the patch i want to use [Checked in: Comment 6]
Attachment #130555 - Attachment is obsolete: true
Attachment #130555 - Attachment description: the patch i want to use [Checked in: Comment 6] → (Av1) |rv| removal [Checked in: Comment 6]
Attachment #137785 - Flags: superreview?(roc)
Attachment #137785 - Flags: review?(mozeditor)
file a new bug about the comment
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #137785 - Attachment description: (Bv1) |@return| update → (Bv1) |@return| update [Moved to bug 229102]
Attachment #137785 - Attachment is obsolete: true
Attachment #137785 - Flags: superreview?(roc)
Attachment #137785 - Flags: review?(mozeditor)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: