214552 - warning: unused variable `nsresult rv' In member function `virtual nsresult nsMenuItemX::DoCommand()'

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[timeless]

/Users/timeless/mozilla/widget/src/cocoa/nsMenuItemX.cpp: In member function
   `virtual nsresult nsMenuItemX::DoCommand()':
/Users/timeless/mozilla/widget/src/cocoa/nsMenuItemX.cpp:257: warning: unused
   variable `nsresult rv'

Comment 1

[Ben Fowler]

This diff which is small enough to apply by hand fixes the warning

Index: widget/src/cocoa/nsMenuItemX.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/cocoa/nsMenuItemX.cpp,v
retrieving revision 1.10
diff -r1.10 nsMenuItemX.cpp
285c285,286
<   return nsEventStatus_eConsumeNoDefault;
---
>   rv =  nsEventStatus_eConsumeNoDefault;
>   return rv;

but I am not sure that the comment about the return from this function
is quite accurate.

Comment 2

[timeless]

Attachment: (Av1) |rv| removal [Checked in: Comment 6]

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 130555 [details] [diff] [review]
(Av1) |rv| removal
[Checked in: Comment 6]


'approval1.6=?': Trivial unused code removal.
(if not too late)

Comment 4

[tor]

Comment on attachment 130555 [details] [diff] [review]
(Av1) |rv| removal
[Checked in: Comment 6]

Too late in the 1.6 timeframe for changes that aren't serious
regressions, security, or crash related.

Comment 5

[Serge Gautherie (:sgautherie)]

timeless (or anyone):
Can you check in your r+&sr+ patch ? Thanks.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 130555 [details] [diff] [review]
(Av1) |rv| removal
[Checked in: Comment 6]


Check in: { 12/20/2003 20:27	timeless%mozdev.org	1.12 }

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) |@return| update [Moved to bug 229102]

As suggested by comment 1.

Comment 8

[timeless]

file a new bug about the comment