214727 - can't add bookmark while page is loading in background

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Jeremy M. Dolan]

Comment 1

[Jeremy M. Dolan]

Oops, accidentally hit enter while initially entering the summary. Here goes:
---

OK, so I've been having "Add Bookmark" occasionally silently not work for the
past few months, and finally have found the cause.

I have a page here, full of links to a site that is very unresponsive. If I
middle-click a link to open it in a new tab in the background, selecting add
bookmark from the menu does nothing. It closes the menu but the dialog does not
pop up. If I close the "Loading..." tab, or select it, and then return to the
first, bookmarking works properly.

Also, if I middle click e.g. ten links, I can't bookmark a page unless I close
all ten of them.

The site is now back up, so you may need to setup your own unresponsive service
on port 80 (netcat? perhaps it needs to be before the SYN,ACK? A packet
filtering firewall should work), or find a site that just hangs to test.

Comment 2

[Thomas Hettenhausen]

(In reply to comment #0)
>  

I can verify this behaviour for Windows as well, right now I am running Firefox 0.8.

I only have to add that I found this bug to not only occur when the new links
are on unresponsive sites, but whenever they are not fully loaded.

Go to a gallery/graphics site (e.g. deviantart.com, or some photography site, or
wallpaper downloads, ...), and load a lot of links in the background (just
enough so that Firefox is still loading in one or two of them, and then press
CTRL-D. Nothing will happen. Repeat when all tabs with all images are fully
loaded, and it will bring up the bookmarking dialog. Only once though, it will
not miraculously trigger a dialog for the first CTRL-D with some latency or
something.

The OS for this bug should be set to all, since it is obviously affecting Win32
and Linux builds.

Comment 3

[Dimitrios]

Finally I found this bug report. I see the reported behaviour from the
beginning. Steps to reproduce are exactly those reported in comment #2. It
usually needs 2-3 loading tabs for the bookmarking to become non-functional
(neither shortcut nor menu bookmarking works). Perhaps it is not as easy to
reproduce on fast connections but I am very frequently stuck on this when I the
sites I visit are modestly graphics intensive.

Comment 4

[Dimitrios]

IMO, Failing to bookmark a page is something totally unacceptable for a final
release. Nominating for 1.0. 

Comment 5

[Mike Connor [:mconnor]]

*** Bug 250998 has been marked as a duplicate of this bug. ***

Comment 6

[Asa Dotzler [:asa]]

Vlad, can you take a look at this please? 

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

+ing for investigation. 

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Not a "blocker"

Comment 9

[Dan]

I think my issue is related, so I won't make a new bugreport yet. Maintainers,
please let me know if it is apropriate to create a new report.

My problem is I cannot open a bookmark in a new tab, if the current tab is in
the middle of a load (/.ed). If I middle-click on my bookmarks toolbar to open
one of my bookmarks in a new tab while a tab is trying to load, the bookmark
gets opened in the tab that is trying to load, not a new one.

Comment 10

[Worcester12345]

needs aviary landing keyword

Comment 11

[Hixie (not reading bugmail)]

no it doesn't

Comment 12

[Worcester12345]

Shouldnt (Cant type apostrophes any longer due to bug.) this be under bookmarks
component?

Comment 13

[Seairth Jacobs]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716
Firefox/1.0.6

I have not been able to reproduce this.  Can someone confirm if this is still a
problem?

Comment 14

[Dimitrios]

Can no longer reproduce it too, for a while (maybe more than a month).

Comment 15

[Mike Connor [:mconnor]]

WFM 1.5 RC2, resolving, clearing nomination.