215838 - Customize dialogue should allow to align text of the Icons on the right side (like in IE)

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, enhancement)

Description

[Jan Sammler]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

The customize dialogue allows the user to select "Show: Icons and Text" to
display a text underneath the icons on the toolbars. Tough it costs some space
in the toolbars, the users would appreciate an option to display this text on
the right of the icons.

Reproducible: Always

Steps to Reproduce:
1. Open the customize dialogue.
2. Click on the Dropdown near "Show:".
3. The dropdown produces a list with the items "Icons and Text", "Icons" and Text".

Actual Results:  
The dropdown is missing another item called "Icons and Text on right"

Expected Results:  
Mozilla Firebird should have included an item to align the text of the icons on
the right side.

Comment 1

[Simon Paquet [:sipaq]]

Confirming enhancement request. Tweaking summary.

Comment 2

[Jan Sammler]

The bug appears with the setting "Show text", too.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

feature. -ing. 

Comment 4

[Jon Henry]

I have a mostly-working patch for this. The one hangup is that the setting
doesn't take effect until the user clicks Done. I don't understand why this is,
since the other modes work and my changes are only in CSS pretty much. If anyone
has a suggestion, I would appreciate it.

Comment 5

[Jon Henry]

Attachment: Patch

Comment 6

[Jon Henry]

Comment on attachment 148593 [details] [diff] [review]
Patch

Mike, if you could look at this when you have the time, I would appreciate it.

Comment 7

[Jon Henry]

Comment on attachment 148593 [details] [diff] [review]
Patch

Canceling my review request for now, there has to be a better way to do this...

Comment 8

[Jon Henry]

Attachment: Better patch

This patch does everything it's supposed to, and fixes a couple logic errors I
uncovered in the process that got in the way as well. After browsing with this
mode enabled for a little while, I actually like it a lot. It lets us clearly
label the buttons (which is nice for the less tech-savvy), but doesn't eat up
any vertical space from the content pane.

Regarding the line about bug 193298, I was in that function anyway and between
my observations and comments in that bug, it seems safe to delete the extra
removeChild and perhaps resolve bug 193298 as WFM.

Comment 9

[Jon Henry]

Comment on attachment 151682 [details] [diff] [review]
Better patch

Mike, could you please take a quick look at this when you have time?

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 151682 [details] [diff] [review]
Better patch

the actual mechanics look good, but I don't think I like the UI bits.  I
actually don't like the current UI bits anyway, so I won't worry about that in
the context of this bug.

Comment 11

[Jon Henry]

I don't have checkin privlidges, so if this could land at some point that would
be great. Also, if you have any ideas as to how this UI could be improved I
wouldn't mind working on it, since I've already been digging around in the
customization code.

Comment 12

[Asa Dotzler [:asa]]

blake, can you look this over and get it in? 

Comment 13

[Ross Shannon]

The intended behaviour this bug is looking for doesn't actually match IE's
toolbar behaviour, but is a valid request itself. Once this enhancement is made
we can go the extra mile and add "Selective text on right," cf bug 258607.

Comment 14

[John Hawkins]

Has this bug died? (apologies for spam)

Comment 15

[Mike Connor [:mconnor]]

I don't think this is important anymore.