216187 - Fix Windows icon association and reenable it.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Brian 'netdragon' Bober]

Based off bug 214798. The icons images in Explorer are replaced with the Mozilla
application icon. They should only be associated with Mozilla, but show the
actual contents of the icon file. This is from bug 99380 originally.

[HKEY_CLASSES_ROOT\icofile\DefaultIcon]
@="%1"
"PictureID"="0"

Comment 1

[Brian 'netdragon' Bober]

*** Bug 216186 has been marked as a duplicate of this bug. ***

Comment 2

[Jez]

Wasn't this bug filed a little prematurely?  The patch that removes Mozilla's
ability to associate with .ico hasn't been checked in yet.

Comment 3

[Brian 'netdragon' Bober]

Not really, because it will still have to be fixed if not disabled.

Comment 4

[Brian 'netdragon' Bober]

I don't think its a good idea after we re-enable the icon code to change what is
displayed as the icon image on startup, but simply we should leave it as-is. If
these two patches are submitted in quick succession, and they miss the build
that resets the pref, and they do associate icons with Mozilla, then they will
have to go into preferences > Advanced > System and that will redo the function
ico.set() and clean up the icons. How does that sound?

Its too bad Mozilla doesn't have something equivalent to "runonce" in the
registry (or does it) or something like NS_RUNONCE / NS_RUNONCE_END :-)

I'm just afraid we might irk people off that have chosen an icon to represent
icon images (perhaps they don't want the icons' thumbnails visible within
explorer) and we would change this each time Mozilla started. I know currently
few if any probably associate it with Mozilla, but it might change in the
future. Besides, its extra code we really don't need.

Sound good?

Comment 5

[Brian 'netdragon' Bober]

[e-mail] 2003-08-17 said in bug 99380:

If you want to reset the ICO icons exactly once, all you need to do is to check
for the existence of the following *value*
HKEY_LOCAL_MACHINE\Software\Classes\MozillaICO\DefaultIcon
of the key HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Desktop
and if it exists, remove it and reset the MozillaICO icon
...new versions of mozilla should never create that value, of course...

Comment 6

[Brian 'netdragon' Bober]

Lol. And the funny thing is this value this reg entry holds doesn't even seem to
be correct:

C:\PROGRA~1\COMMUN~1\mozilla.org\Mozilla\chrome\icons\default\IMAGE-~1.ICO,0

Its almost like an unused reg entry. That would be excellent. I'll have to
investigate more.

Comment 7

[[e-mail]]

Attachment: Possible patch

This makes it so that when Mozilla associates icons with itself they display as
themselves in Explorer - whatever they used to display as.

Comment 8

[Dan M]

Comment on attachment 136176 [details] [diff] [review]
Possible patch

I've never been in this file before, so I'm not terribly qualified. But I'm not
sure who's active that I'd recommend to review instead, and I guess I've
grokked the patch, so...

Code seems fine; seems to work; seems like a good idea to me; I'll slap a + on
it.

Comment 9

[rbs]

Comment on attachment 136176 [details] [diff] [review]
Possible patch

sr=rbs, sounds a reasonnable idea.

Comment 10

[[e-mail]]

Comment on attachment 136176 [details] [diff] [review]
Possible patch

Marking rbs's sr; requesting approval because this is a highly visible issue
for windows users.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 136176 [details] [diff] [review]
Possible patch

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[Jez]

Well.  Now that this has been fixed, could you possibly sort out the icons for
Mozilla's associated filetypes in Windows by getting it to use the icons in bug
#99380?  I don't really see what your problem is with this, Neil.  Having the
Mozilla app icon for every associated filetype looks rather ugly.

Comment 14

[[e-mail]]

This one turned out to be easier to fix, so I did it first.

Comment 15

[Brian 'netdragon' Bober]

As far as i remember, the patch in bug #99380 still needs a few things fixed.

Verified

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 129825 has been marked as a duplicate of this bug. ***