Closed Bug 216214 Opened 21 years ago Closed 12 years ago

IM only supports AIM - request: support other IM tools

Categories

(Thunderbird :: Address Book, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird15 fixed)

RESOLVED FIXED
Thunderbird 11.0
Tracking Status
thunderbird15 --- fixed

People

(Reporter: bse, Assigned: raccettura)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: Mozilla Thunderbird 0.2a (20030807)

The "Screen Name" field in the address book refers to AIM only - how i found 
out after 5 minutes of wondering, because the only hint you get is the AIM icon 
when viewing a card in the main window.

However even if Mozilla/Thunderbird is the source of Netscape and Netscape is 
owned by AOL-TimeWarner, there should be support for other IM clients too, like 
ICQ, MSN, Y!M. 
If you can't add support for all, please add support for ICQ at least - it also 
belongs to AOL ;)


Reproducible: Always

Steps to Reproduce:
Target Milestone: --- → After Thunderbird 1.
QA Contact: asa
Depends on: 223499
Maibe it would be best to make it an extention
I agree to Bernhard Seibold, natively supporting ICQ (at least!), MSN, AIM and
Yahoo! should be seriuosly considered
Taking.  I have a patch.
Assignee: mscott → robert
OS: Windows XP → All
Attached patch Patch v1Splinter Review
My first attempt.  Be kind.
Attachment #141213 - Flags: review?(bienvenu)
I guess I should explain:

I added two preferences:
mailnews.addressbook.goimIMG - URL For image to use

mailnews.addressbook.goimURL - URL to launch IM protocol.

This allows the user to customize their Screenname field to support any protocol
of choice.

Note this is profile wide, not AB specific, or card specific.

No UI, just preference.  Perhaps later to make a UI.  Who knows.  If anyone has
an opinion, of course make your case heard.  Personally I've got mixed feelings.  


I think ideally mailnews.addressbook.goimURL should be able to launch an
application, as I don't think MSN/Windows Messenger for example can be launched
via a URL.  Not quite sure how to do that.
Hardware: PC → All
I think programs can be launched from a URL if the URL begins with file:// (for example, file://
HardDisk:Applications:MSN%20Messenger.app:Contents:MacOS:MSN%20Messenger)...   Not sure about 
Windows but something like "file://HardDisk|/Program%20Files/MSN%20Messenger/msmsgr.exe" 
would probably work.
Most likely.  Wasn't sure though.
Status: NEW → ASSIGNED
Scott,

I know a lot of people at mozillazine.org forums think the AB isn't to flexible.
 Perhaps this patch adds at least a tiny bit of flexibility?

It could at least then be mapped to Yahoo, MSN, or really any other app they
want.. in theory doesn't even need to be chat.
David,

Can we put this on your radar for review?  Adding this would be nice.  Not
everyone likes AIM.  Were able to be flexible.

A part 2 for this patch could be a frontend to allow for customization.  Perhaps
as an extension.  Shouldn't be to hard for anyone with the time.
Comment on attachment 141213 [details] [diff] [review]
Patch v1

I don't think you need to check the pref type to see if it's string or not.

Are there actual urls in the real world we can put in for the img?
Attachment #141213 - Flags: superreview?(sspitzer)
There of course are... but I didn't include anything for copyright reasons.  Not
sure what the rules are on that.

Perhaps the folks from GAIM (http://gaim.sf.net) would know?
robert, thanks for starting this.

I think there might be other "support things other than AIM" bugs logged against
mozilla mailnews that would be worth reviewing.

I'll look for them and then help with reviews.
Seth,

There were a giant bunch.  I did dup/resolve a few back in February IIRC.

There's also: bug 223499

As well as bug 218714

My main opinion on the AB itself is here:
http://bugzilla.mozilla.org/show_bug.cgi?id=171080#c6

I think it's worth exploring post-1.0.  It's the weakest component, looking at
reviews.  And obviously, looking at how things have improved (and AB is pretty
dormant).  With a good remodeling, it could be a great app.

Not sure what bug 213361 is about, but I assume it's IM related.
Adding support for Jabber-IDs would be nice
Comment on attachment 141213 [details] [diff] [review]
Patch v1

Sorry for the huge delay. Is this patch still valid? I've seen other things going on in this area, iirc.
(In reply to comment #4)
> Created an attachment (id=141213) [edit]
> Patch v1
> 
> My first attempt.  Be kind.

Is this patch effective?
like xfire, msn, yahoo, AIM, ICQ, Google talk 
Comment on attachment 141213 [details] [diff] [review]
Patch v1

we probably want something like this - but this patch seems to declare goimURL twice - is that kosher in js, or can the second line just be:

  goimURL = goimURL + card.aimScreenName;

?
Attachment #141213 - Flags: superreview?(sspitzer) → superreview?(mscott)
QA Contact: address-book
Comment on attachment 141213 [details] [diff] [review]
Patch v1

I like where this patch is going. Two things jump out at me:

1) goimURL is declared twice as David points out.

2) I think we should move the AOL settings over to prefs instead of hard coding the values in the catch statements in JS. 

I would vote for calling the pref something that's not AB specific in case we use it somewhere else, maybe:

mail.instant_message_url

?
Attachment #141213 - Flags: superreview?(mscott) → superreview-
Comment on attachment 141213 [details] [diff] [review]
Patch v1

clearing review request since scott minused it.
Attachment #141213 - Flags: review?(bienvenu)
Not that the gContactSync Add-on already add several Instant Messaging field in the Thunderbird Adress Book, in order to synch them with GMail.

Source: http://www.pirules.net/gcontactsync/index.html

Look at the screenshoots to have a better idea of how it works.
I am closing this bug as TB15 now add support for 8 instant messaging protocol in the address book:
Google talk
Aim
Yahoo
Skype
QQ
MSN
ICQ
Jabber
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: