If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[gtk2]tooltip make mozilla crash on Solaris

RESOLVED FIXED

Status

Core Graveyard
GFX: Gtk
--
critical
RESOLVED FIXED
14 years ago
9 years ago

People

(Reporter: Robin Lu, Assigned: Robin Lu)

Tracking

({crash})

Trunk
Sun
Solaris
crash

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.06 KB, patch
Brian Ryner (not reading)
: review+
blizzard
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

14 years ago
When using classic theme, mozilla init the tooltips widget in gtk2drawing.c like:

static gint
ensure_tooltip_widget()
{
    if (!gTooltipWidget) {
        gTooltipWidget = gtk_tooltips_new();
        gtk_tooltips_force_window(gTooltipWidget);
        gtk_widget_set_rc_style(gTooltipWidget->tip_window);
        gtk_widget_realize(gTooltipWidget->tip_window);
    }
    return MOZ_GTK_SUCCESS;
}
This causes crashes of mozilla on solaris as same as bug 140698 .
(Assignee)

Updated

14 years ago
Summary: tooltip make mozilla crash on Solaris → [gtk2]tooltip make mozilla crash on Solaris
(Assignee)

Comment 1

14 years ago
Created attachment 130113 [details] [diff] [review]
patch
(Assignee)

Updated

14 years ago
Attachment #130113 - Flags: review?(blizzard)
(Assignee)

Comment 2

14 years ago
Created attachment 130151 [details] [diff] [review]
patch sync with current trunk
Attachment #130113 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #130113 - Flags: review?(blizzard)
(Assignee)

Updated

14 years ago
Attachment #130151 - Flags: review?(blizzard)

Updated

14 years ago
Severity: normal → critical
Attachment #130151 - Flags: review?(blizzard) → review?(bryner)
Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk

looks ok to me.
Attachment #130151 - Flags: review?(bryner) → review+
(Assignee)

Comment 4

14 years ago
Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk

Thanks, bryner!
Attachment #130151 - Flags: superreview?(blizzard)
Comment on attachment 130151 [details] [diff] [review]
patch sync with current trunk


>-        g_object_unref(gTooltipWidget);
>+        gtk_widget_destroy(gTooltipWidget);

I think this leaves a floating tooltip widget.	If I remember correctly,
gtk_widget_destroy() does not unref, it merely destroys the representation of
it.
Attachment #130151 - Flags: superreview?(blizzard) → superreview-
(Assignee)

Comment 6

14 years ago
> I think this leaves a floating tooltip widget.	If I remember correctly,
> gtk_widget_destroy() does not unref, it merely destroys the representation of
> it.

The gTooltipWidget is not a GtkTooltip any longer. It is a GtkWindow instead.
Only used for tooltip style.
The same thing applies, though.
(Assignee)

Comment 8

14 years ago
GtkWindow is a toplevel window and no one owns it. It calls the gtk_object_sink
in its init ( see gtk_window_init in gtkwindow.c ). I think we can just call
gtk_widget_destroy as we do the same thing to gProtoWindow. Currect me if I am
wrong.
Attachment #130151 - Flags: superreview- → superreview+
(Assignee)

Comment 9

14 years ago
checked in trunk.
bryner and blizzard, thanks!
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.