217029 - error message on mecha for "View Bugs Already Reported Today"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Matthias Versen [:Matti]]

a) click the link "View Bugs Already Reported Today"
b) get an error :  '' is not a legal date.

(using a current trunk win2k Mozilla as client)

Comment 1

[Matthias Versen [:Matti]]

I suck

Comment 2

[Myk Melez [:myk] [@mykmelez]]

*** Bug 217042 has been marked as a duplicate of this bug. ***

Comment 3

[Myk Melez [:myk] [@mykmelez]]

mothra is running Date::Parse version 2.09; mecha's running 2.27.  The behavior
is different:

mothra:bugzilla> perl -e'use Date::Parse; print $Date::Parse::VERSION . ": " .
str2time("") . "\n";'
2.09: 1061535600

[root@mecha bugzilla]# perl -e'use Date::Parse; print $Date::Parse::VERSION . ":
" . str2time("") . "\n";'
2.27:

Bugzilla/Search.pm expects str2time("") to return the current time, so it balks
when it gets an undefined time back from the newer version of the function.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Fixed on mecha with an explicit check for an empty string.  Moving this bug over
to the Bugzilla product so the underlying Bugzilla problem can be addressed.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: simple fix that checks for empty string

This patch simply checks to see if the date string is empty and creates its own
date string if so.  We can't just return date2str(str2time(time)) or something
like it because current behavior is to return a string representing the
beginning of the day (i.e. "yyyy-mm-dd 00:00:00") if no date is given.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.44; previous revision: 1.43
done

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.44; previous revision: 1.43
done