217422 - "0" is missing in "votes: 0" (MySQL 4)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Jesse Ruderman]

In bugs with 0 votes, the "0" doesn't appear.  In a bug with more than 0 votes,
the number does appear.


Dave Miller says:

mysql> select sum(votes.count) from votes where bug_id=216434;
+------------------+
| sum(votes.count) |
+------------------+
|             NULL |
+------------------+
1 row in set (0.00 sec)

MySQL 4 returns NULL if there were no matching values to count.  MySQL 3.23
returned 0.

Comment 1

[Dave Miller [:justdave]]

This is in Bug.pm. fixing component

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 130454 [details] [diff] [review]
Patch

Won't work in pg, but r=bbaetz since we don't have an abstraction layer for
hose sort of non-standard mysql-isms yet.

Comment 4

[Dave Miller [:justdave]]

Checking in Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.33; previous revision: 1.32
done

Comment 5

[Dave Miller [:justdave]]

Low risk, needed for MySQL 4 compatibility.  Nominating for 2.16 branch.

Comment 6

[Dave Miller [:justdave]]

Attachment: Patch for 2.16 branch (incomplete - see comment 8)

Comment 7

[Dave Miller [:justdave]]

checked in on 2.16 branch

Checking in Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.12.2.1; previous revision: 1.12
done

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 132158 [details] [diff] [review]
Patch for 2.16 branch (incomplete - see comment 8)

FYI to anyone watching this bug, the patch for the 2.16 branch on this bug is
broken/incomplete.  There is a corrective patch on bug 225474.