blank file name in download dialog causes crash

VERIFIED FIXED in M13

Status

P1
critical
VERIFIED FIXED
19 years ago
14 years ago

People

(Reporter: tever, Assigned: pavlov)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
Overview Description:  I am seeing a crash when I do not supply
a filename for ftp download.  (In Linux only)

Steps to Reproduce:
1.)  Go to ftp://sweetlou or some ftp site
2.)  select a file to download and select save in your download dialog
3.)  In the 'Save File' dialog do not supply a file name and select OK
4.)  the 'Replace' dialog will display "Replace file ""?"   Select replace.

Actual Results:  Program terminates

Expected Results:  I would expect some sort of error handling message.

Build Date & Platform Bug Found:
1999121508  Linux
(Reporter)

Updated

19 years ago
QA Contact: leger → tever
(Reporter)

Comment 1

19 years ago
re-assigning QA contact to myself

Updated

19 years ago
Severity: normal → critical

Updated

19 years ago
Priority: P3 → P1
Target Milestone: M13

Comment 2

19 years ago
Move to M13.

Updated

19 years ago
Status: NEW → ASSIGNED
OS: Windows NT → Linux

Comment 3

19 years ago
Probably the file widget code is different on Linux.  We'll have to either
handle that in nsIFileWidget or deal with it in the stream xfer code.

Comment 4

19 years ago
cc:ing sairuh, this probably is under her QA realm

Comment 5

19 years ago
Is this related to bug #23885 (Bad crash when opening nonexistant file)?

Comment 6

19 years ago
Probably not related.  This one seems specific to linux, that other one seems
present on windows, also.

Updated

19 years ago
Assignee: law → pavlov
Status: ASSIGNED → NEW

Comment 7

19 years ago
pavlov and I discussed this bug.  I've got the following patch (which treats

entry of a blank file name (directory path) the same as cancel) but I'm turning

it over to him.



Index: nsFileWidget.cpp

===================================================================

RCS file:

/cvsroot/mozilla/widget/src/gtk/nsFileWidget.cpp,v

retrieving revision 1.35

diff

-r1.35 nsFileWidget.cpp

418c418,423

<     if( theFileSpec.Exists() )

---

>

if( theFileSpec.IsDirectory() )

>     {

>       // Can't put to a directory.

>

    theResult = nsFileDlgResults_Cancel;

>     }

>     else if(

theFileSpec.Exists() )
(Assignee)

Updated

19 years ago
Status: NEW → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

19 years ago
checked in fix
(Reporter)

Comment 9

19 years ago
verified Linux 2000012401
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.