21873 - blank file name in download dialog causes crash

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Tom Everingham]

Overview Description:  I am seeing a crash when I do not supply
a filename for ftp download.  (In Linux only)

Steps to Reproduce:
1.)  Go to ftp://sweetlou or some ftp site
2.)  select a file to download and select save in your download dialog
3.)  In the 'Save File' dialog do not supply a file name and select OK
4.)  the 'Replace' dialog will display "Replace file ""?"   Select replace.

Actual Results:  Program terminates

Expected Results:  I would expect some sort of error handling message.

Build Date & Platform Bug Found:
1999121508  Linux

Comment 1

[Tom Everingham]

re-assigning QA contact to myself

Comment 2

[don]

Move to M13.

Comment 3

[Bill Law]

Probably the file widget code is different on Linux.  We'll have to either
handle that in nsIFileWidget or deal with it in the stream xfer code.

Comment 4

[Paul MacQuiddy]

cc:ing sairuh, this probably is under her QA realm

Comment 5

[don]

Is this related to bug #23885 (Bad crash when opening nonexistant file)?

Comment 6

[Bill Law]

Probably not related.  This one seems specific to linux, that other one seems
present on windows, also.

Comment 7

[Bill Law]

pavlov and I discussed this bug.  I've got the following patch (which treats

entry of a blank file name (directory path) the same as cancel) but I'm turning

it over to him.



Index: nsFileWidget.cpp

===================================================================

RCS file:

/cvsroot/mozilla/widget/src/gtk/nsFileWidget.cpp,v

retrieving revision 1.35

diff

-r1.35 nsFileWidget.cpp

418c418,423

<     if( theFileSpec.Exists() )

---

>

if( theFileSpec.IsDirectory() )

>     {

>       // Can't put to a directory.

>

    theResult = nsFileDlgResults_Cancel;

>     }

>     else if(

theFileSpec.Exists() )

Comment 8

[Stuart Parmenter]

checked in fix

Comment 9

[Tom Everingham]

verified Linux 2000012401