218927 - basic auth: "remember this password" checkbox should be checked if password was remembered

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Bob Firth]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030910 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030910 Firebird/0.6.1+

Remember password checkbox is unchecked even though password has been remembered
by password manager.

Reproducible: Always

Steps to Reproduce:
1. go to site requiring password authentication
2. enter username/password + check "User Password Manager to remember this
password" checkbox
3. close browser
4. go to same site again.

Actual Results:  
Username and password filled in, but checkbox is unchecked

Expected Results:  
Checkbox should be checked if the password is remembered by password manager.

If you check remember checkbox a duplicate entry will be remembered by password
manager.

This is under Firebird because it only happens in firebird, it works fine for
Mozilla.

Comment 1

[Bob Firth]

This doesn't occur on Firebird 0.6.1 milestone.
Added keyword: regression

Comment 2

[Mike Connor [:mconnor]]

Password manager remembers the user/pass, as designed.  If that's checked (i.e.
MZ forums), the saved cookie should prevent you from seeing the sign-in page. 
The checkbox isn't supposed to be saved by password manager.

-> bryner, to make sure I'm not crazy in thinking this is working properly.

Comment 3

[Bob Firth]

sorry, I don't think you've understood which checkbox I mean...

I'm talking about sites that ask for username/password authentication to access
them e.g. proxy server or restricted subdomains, not sites that use cookies.
When the prompt is popped up, there is are two text fields and a checkbox as
part of the mozilla UI (not site dependant).

Hope that's a bit clearer.

Comment 4

[David P James]

Moving all active Password Manager bugs to Autocomplete component with
[pwd-mngr] in summary for querying. Sorry for the bugspam.

Comment 5

[Bob Firth]

I see this in Linux too (Gecko/20031007 Firebird/0.7)
OS -> All

Comment 6

[Bob Firth]

*** Bug 222955 has been marked as a duplicate of this bug. ***

Comment 7

[Darin Fisher]

*** Bug 228108 has been marked as a duplicate of this bug. ***

Comment 8

[Brian Ryner (not reading)]

Attachment: patch

Comment 9

[Brian Ryner (not reading)]

This doesn't address the duplicate entry issue, but I think I have a handle on that.

Comment 10

[Brian Ryner (not reading)]

Attachment: patch #2

fix both issues.  AddUser needs to look for an existing entry, and if it finds
one, just update the password.

Comment 11

[Brian Ryner (not reading)]

Checked in.

Comment 12

[David P James]

v.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031212 Firebird/0.7+