Closed
Bug 21895
Opened 26 years ago
Closed 26 years ago
[DOGFOOD] spacebar key seemed to have linked with pagedown event unintentionally.
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P3)
Core
DOM: UI Events & Focus Handling
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: racham, Assigned: hyatt)
References
()
Details
(Whiteboard: [PDT+])
I was in the process of updating a bug and typing stuff in the text area. After
a while, hitting spacebar moved me a page down. Hit space one more time, I'm at
the bottom of the page. Spaces have been written properly but the bad
side-effect is that you just moved the page down in the processing putting a
white space. This is reproducible on Win NT with 15th's 6pm commercial build.
Updated•26 years ago
|
Summary: [dogfood]spacebar key seemed to have linked with pagedown event unintentionally. → [DOGFOOD] spacebar key seemed to have linked with pagedown event unintentionally.
Comment 1•26 years ago
|
||
This is a regression, boo :(
Comment 2•26 years ago
|
||
I've seen this in web forms and in the editor in mail/news, too.
Updated•26 years ago
|
OS: Windows NT → All
Hardware: PC → All
Comment 3•26 years ago
|
||
Excerpt of IRC conversation explaining the problem:
<akk> Apparently the browser controller and keybindings are stacked on top of
the editor ones,
<akk> and apply to all dom windows.
<smfr> that seems broken
<akk> So when editorBindings.xul doesn't handle a space (because it's going to
be passed through to the editor),
<akk> browserBindings.xul grabs it.
<smfr> can we pretend to handle it, and do nothing?
<akk> I tried hacking a nop command into nsEditorController, and then making
space in editorBindings call nop in the editor controller.
<smfr> or does that mean we lose the space key
<akk> That works great -- but Mike pointed out that it's a bug that it works.
<akk> It only works because xul isn't consuming events after acting on them (the
double-paste bug),
<akk> and saari is supposed to be fixing that.
<smfr> mmmm
<akk> We could of course take the spacebar out of browserBindings.xul. But then
space wouldn't page down in the browser.
<smfr> it sounds like we need 'browser commands', 'editor commands', and
'generic dom window commands'
<smfr> so the browser windows uses browser and generic, and we use editor and
generic
<akk> Mike is going to take space out of browserBindings.xul and check it in
right now, to make the editor usable while we figure out what to do.
<akk> smfr: We have all that! The problem is that editor windows and browser
windows have browser commands stacked on top of the editor commands.
Updated•26 years ago
|
Assignee: joki → mjudge
Comment 4•26 years ago
|
||
looks like mjudge/akkana/hyatt are on the case, over to mjudge.
Updated•26 years ago
|
Target Milestone: M12
Comment 6•26 years ago
|
||
final m12 candidates are spinnning now. moving to m13.
if we fall off track and need to respin m12 for some
yet unknown reason we can consider this if you get
a fix in hand.
Comment 7•26 years ago
|
||
I'm posting this update with win32 12/16/08.
Is this platform or configuration specific?
seem to work for me.
Comment 8•26 years ago
|
||
Well, I know it shows up on linux.
Comment 9•26 years ago
|
||
also seems to work for me on linux 12/16/08 release build
Comment 10•26 years ago
|
||
er, 12/16 08:00 build.
| Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 11•26 years ago
|
||
I just checked in a fix for this.
Comment 12•26 years ago
|
||
trying to reproduce this bug with 1999121608 windows build... i can enter text
into this area "Additional Comments", but all the other form submission text
fields are affected.
Updated•26 years ago
|
Target Milestone: M13 → M12
Comment 13•26 years ago
|
||
we will move hyatt's checkin to the m12 branch
Comment 14•26 years ago
|
||
Mjudge checked in a workaround that disabled the spacebar bindings (so it
wouldn't scroll down in browser windows either), so builds pulled yesterday
afternoon won't see the problem (but spacebar won't page down, either). I think
that made it into M12. Hyatt's later fix addresses the backend problem and
should allow us to turn the spacebar back on in places (like the browser window)
where it's supposed to be there.
Updated•26 years ago
|
Status: RESOLVED → REOPENED
Comment 15•26 years ago
|
||
I am still seeing this.
Linux, clobbered my build last night,
just pulled around 9am this morning.
Updated•26 years ago
|
Assignee: mjudge → hyatt
Status: REOPENED → NEW
Comment 16•26 years ago
|
||
akkana says over to hyatt
Comment 17•26 years ago
|
||
Clearing FIXED resolution due to reopen.
Comment 18•26 years ago
|
||
reproduced using today's opt comm bits on Linux, only single-line edit fields
are still affected.
Comment 19•26 years ago
|
||
I can reproduce this in the multi-line text area of a long
bugzilla report, like this one :-) This morning's NT build
seems be working Ok though.
Comment 20•26 years ago
|
||
I would like to take a fix in the m12 branch for this,
if we find one in time.
Comment 21•26 years ago
|
||
Using Build 1999121612. Clearing up the air.
This bug can "appear" fixed because of this:
1) Load this bug up.
2) Open your side bar, (if not already open).
3) Scroll down so that you can see the Additional Comments field.
4) Click on something in your side bar, blank space or a bookmark is just fine
(just don't go anywhere).
5) Click into the Additional comments field.
6) Start typing. notice spaces don't scroll.
This is because the page doesn't actually have the focus. My assumption is the
sidebar still has the focus. To show you why I think that, click on the web page
somewhere and then back into the comments section. Then watch as spaces cause
the page to scroll.
Comment 22•26 years ago
|
||
Here is an easy way to reproduce on M12 Candidate builds from 12/17:
simply go to http://www.yahoo.com, click in search form, and press the spacebar.
M12 just can't be shipped without a fix for this.
Comment 23•26 years ago
|
||
Thanks! Yes, I see it with paulmac's instructions (where I didn't see it in
bugzilla).
Comment 24•26 years ago
|
||
I am seeing this in bugzilla, I now type my comments
in bugs FROM MEMORY as the page scrolls down and
I no longer see what I am typing. Uh, this is bad.
Comment 25•26 years ago
|
||
Another example, http://lxr.mozilla.org, search for something
in the Sea Monkey tree with spaces in it, boom! you scroll. (WinNT)
| Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 26•26 years ago
|
||
Fixed.
Comment 27•26 years ago
|
||
Can someone check this into M12 branch and possibly fire off some builds ASAP?
It would be nice to play with these builds over the weekend so we can get rid of
this M12 thing Monday evening.
Or else, can someone pull M12 branch (once they check this fix in) and zip up a
debug build and post it somewhere?
And if someone wants to check in buster's fix for 21612 (single click in forms),
that would rule also, it didn't make it into M12 branch yet.
I am so needy.
Comment 28•26 years ago
|
||
you can check the fix in the m13 dailies that will
run off the automation over the weekend.
Comment 29•26 years ago
|
||
blizzard is merging the changes to the branch, when he's done, i'll fire off
some tasty new m12 builds. mmm.mmm. good.
Comment 30•26 years ago
|
||
I've disovered that merging these changes isn't trivial since there's already
been changes to those files since the bug fixes went in.
Comment 31•26 years ago
|
||
test post on the 12/19 win32 build. look very good.
can't make it scrollg in single or multi-line text fields.
Comment 32•26 years ago
|
||
*** Bug 22100 has been marked as a duplicate of this bug. ***
Comment 33•26 years ago
|
||
verified in 12/20 M12 build.
tried both Win+Linux builds. screen no longer jumps down when spacing
in text field.
Comment 34•26 years ago
|
||
I'm checking m12 now, but if it's like today's m13, then this bug is still
happening on win98...
Comment 35•26 years ago
|
||
ok, not happening in M12 and what I saw in M13 is a different bug that's harder
to get to happen, and doesn't seem to happen at all in M12.
Updated•7 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•