219017 - [gtk2] key event isn't consumed correctly

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Robin Lu]

1.launch mozilla
2.open Preferences Panel
3.find a page which has combobox, for example, Navigator
4. click the combobox to roll it down
5. press down arrow key

expect: the selection moves down for one column
actual result: the selection moves more than one column. sometimes it goes in a
dead loop until another event (such as mouse click) is triggered.

Comment 1

[Robin Lu]

Attachment: patch

all kinds of consumed should be considered as consumed.

Comment 2

[Christopher Blizzard (:blizzard)]

It sounds to me like the key binding in question isn't setting the right
consumed flag, and this stops default processing.  I think that this will
probably break using hot keys in a gtk app embedding mozilla, for example.

Comment 3

[Pierre Chanial]

I tested and checked Robin's patch into the Mozilla Firebird 0.8 branch, since
this bug plagues our add bookmark dialog and Firebird won't be embedded in gtk2
apps.

I'll dig further, but it seems like for menulist menupopups, the
button_press_event callback is connected twice unlike the menubar ones. Why
should the code test for consumed events? Shouldn't they be sent only once by
gtk to the callback function?

Comment 4

[Christopher Blizzard (:blizzard)]

If Mozilla hasn't consumed the event it should be passed back up the chain to
higher level windows that have a crack at it.  This is mostly for the embedding
case since internally our event dispatcher sends everything to the right node.

Comment 5

[Mike Cowperthwaite]

Dupe of bug 55495?

Comment 6

[Mike Cowperthwaite]

*** Bug 232422 has been marked as a duplicate of this bug. ***

Comment 7

[Vidar Haarr (not reading bugmail)]

WFM with a trunk build from tonight. Not sure why it should work now, though,
but seems like it does.

Comment 8

[Wayne Mery (:wsmwk)]

Do you still see this?

Comment 9

[Andrew Schultz]

WFM with builds back to SeaMonkey1.0.  I don't have older gtk2 builds.

resolving WFM