21909 - view source segfaults

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P1)

Description

[sarnold]

Using View Source causes mozilla to segfault.



I am using debian's m12-pre, based on 12/14's cvs.

Comment 1

[sarnold]

I have reproduced this on two different websites on the internet, as well as

local files. Here is the snippet of the console of what happened near the crash

(this one the local file):



Loading page specified via openDialog

Check if a view source window

 A view

source window



[2]+  Segmentation fault      mozilla

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This works fine for me in 1999-12-15-08-M12, Linux.   Is the problem specific to
those two sites?

Comment 3

[sarnold]

Hmm. I can no longer reproduce it, despite five or six attempts, with both local

files and remote sites that caused it to segfault before. (I am still using

monday 12/14 cvs too!)



*sigh*



Thanks! :)

Comment 4

[Michael Lowe]

works for me with 1999121712 build

Comment 5

[sarnold]

View Source caused crash twice on my linux build. From wed 02/23/00 CVS.

To reproduce, visit http://www.willamette.edu/~kjohnson/ and then click on the
link near the bottom for Favorite Artists or Favorite Visuals. It should open
with ugly underlining on everything. Then, view|page source.

This was repeatable.

Thanks guys. :)

Comment 6

[sarnold]

Another attempt: http://support.teleport.com/faqs/ftpspace.phtml | view page
source --> SEGFAULT. linux kernel 2.0.36, new glibc, mozilla built from
februrary 25th CVS checkout.

That bit about "please fix me" -- I have seen it for some time now. Where can I
find that so I try to code up a fix? (Or is this more a fundamental problem?)

I also added the "crash" and "beta1" keywords -- this causes a crash, and I
don't think people will much appreciate their browser segfaulting when viewing
source and will likely ignore the product after noticing this. Of course, the
PDT team can + or - this as they see fit. :)

Thanks

BrowserViewSource();
 we don't handle eBorderStyle_close yet... please fix me
WEBSHELL+ = 6
assuming d&d is off for Navigator
WEBSHELL+ = 7
WEBSHELL+ = 8
Setting content window
browser.startup.page = 1
startpage = http://www.mozilla.org/
Loading page specified via openDialog
Check if a view source window
 A view source window
got a request
WEBSHELL- = 7

[1]+  Segmentation fault      mozilla

Comment 7

[rickg]

Jan -- we're marking this PDT-, on the assumption that it worksforyou. If you 
see this elsewhere, please reopen.

Comment 8

[Sean Richardson]

Saw this with the 2000-02-29-08-M15 and 2000-03-01-08-M15 nightly binaries
on WinNT 4.0, but only with a page that did not display well either:
http://www.aberdeeninc.com/abcatg/scK7ide.htm -- badly nested tags, presumably
a bad DOM (see bug 29735). Viewing source for http://www.mozilla.org worked, 
for both builds.

Viewing the Favorite Visuals page at http://www.willamette.edu/~kjohnson/ 
caused what appears to be the same crash.

Attaching DrWatson32 log for both crashes with the 2000-03-01-08-M15 build 
-- no idea which thread the crash came in.

Comment 9

[Sean Richardson]

Attachment: Dr Watson log for two crashes viewing source

Comment 10

[Asa Dotzler [:asa]]

Are you guys still seeing this with current builds.  I poked around Bugzilla for
dupes and didn't find any.  If this has cleared up with current builds pleas
resolve it WORKSFORME.  If not let's send this to over to XPApps for a look.

Comment 11

[Sean Richardson]

You're right, changing component to "XPApps". Crash absolutely confirmed with 
2000-03-23-08-M15 on WinNT. Removing [PDT-] for reconsideration. Changing
beta1 keyword to beta2 on the assumption that beta1 has sailed already.

I've never seen a crash when viewing source on a page with squeaky-clean HTML,
but this crash is highly reproducible on many, many pages, including:

http://www.cnn.com/
http://www.microsoft.com/
http://www.infoworld.com/pageone.html

Also, at least one page that should not be treated as HTML at all,
http://technocrat.net/rdf, causes a crash when viewed as source. See bug 29049

All of these crashes are showing up as access violations.  

Comment 12

[sairuh (rarely reading bugmail)]

i cannot seem to crash when doing View > Page Source at the following url's:

http://www.cnn.com/
http://www.microsoft.com/
http://www.infoworld.com/pageone.html

tested using the following opt tip builds:

winNT [mozilla, 2000.03.24.09]
linux [comm, 2000.03.24.10]
mac [comm, 2000.03.24.10]

are you seeing this in the tip or the beta1 branch?

Comment 13

[Sean Richardson]

Retested; getting consistent crashes viewing source for http://www.cnn.com on 
2 WinNT boxen running the .zip version downloaded from the 2000-03-24-09-M15 
directory on ftp://ftp.mozilla.org/pub/mozilla/nightly/ -- mozilla.exe. 
I presume that's a tip build. Plenty of free physical memory. 
Will try in the morning with an nb1b build.

Comment 14

[sarnold]

*** Bug 28462 has been marked as a duplicate of this bug. ***

Comment 15

[sarnold]

I mentioned this in bug 28462 as well -- check to ensure the gfx scrollbars are
turned on when trying to reproduce. I have noticed in the past that using the
"native" (motif?) scroll bars does *not* cause the segfault.

I reproduced on a March 25 CVS build. (Built on linux 2.0.36, run on linux 2.2.13.)

Thanks :)

Comment 16

[don]

Bill, is this us or a Gecko issue?

Comment 17

[don]

Bill, I can't repro this.  I'm moving it to M16 for later investigation ...

Comment 18

[sarnold]

I still see this bug; however, I don't know if I am running the tip or the beta1
branch. (I cvs checkout SeaMonkeyAll...)

I still see it with a CVS build made April Fourth.

Oh well. I learned to just turn off the gfx scroll bars. :)

Thanks

Comment 19

[sarnold]

Sidr, please recheck these URLs. I changed my build setup, and things are
working pretty happily here. I can't reproduce this with the www.willamette.edu
URL, not the aberdeeninc.com URL, it all seems to work, gfx scrollbars and all.
:) I would close this bug as wfm, except for your posting march 24th that says
it still happens...

Comment 20

[sairuh (rarely reading bugmail)]

i cannot get a crash on winNT or linux using today's bits, 2000.04.11.09.

Comment 21

[Sean Richardson]

Sorry I lost track of this bug earlier... late in March, viewing source on 
the same pages that caused a crash was resulting in an empty source window.
No crash. Retested all of the URLs with 2000-04-10-08-M15 on WinNT,
no crashes, but for
  http://www.cnn.com/ and
  http://www.infoworld.com/pageone.html
no source appears within 5 minutes (other pages take as much a 5 seconds to 
show up). That's a distinct bug; I'll file it if I don't see it.

Adding this observation to the previous two comments, marking WORKSFORME.

Comment 22

[sairuh (rarely reading bugmail)]

verif.