Closed Bug 219846 Opened 22 years ago Closed 20 years ago

Display favicons in Bookmarks menu for Mac version

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

Product:
Firefox
Component:
Bookmarks & History
Platform:
PowerPC
macOS
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 46177
Milestone:
Future

People

(Reporter: waynegwoods, Assigned: p_ch)

References

(
URL
)

Details

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030912 Firebird/0.6.1+/jtalkington-nightly Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030912 Firebird/0.6.1+/jtalkington-nightly I'm surprised this has never been noted before, but I can't find any reference in bugzilla or the Firebird forums... Could we please have favicons displayed in the Bookmarks menu, as they are in the Bookmarks sidebar, just like the PC version of Firebird? Unless this is currently impossible with OS X ? I'm not sure. Reproducible: Always Steps to Reproduce: 1.Navigate to a site with a favicon 2.Select Add to Bookmarks... 3.Go back to the Boomarks menu Actual Results: Bookmark listed in the menu, but no favicon Expected Results: Bookmark listed in the menu, with a favicon to the left of it
*** Bug 219847 has been marked as a duplicate of this bug. ***
Implementing this might mean taking a performance hit (when drawing the menu), especially for users with lots of bookmarks.
That's possible. Although it doesn't seem to have been a concern when they added that feature to the Windows version. It slows down menus a tiny bit, which could be annoying. Perhaps making it a switchable option might be appropriate (for both versions). I don't know how easy this is to implement for OS X, compared to Windows (if it's even possible). But I thought that if it was possible, then OS X would probably handle the graphics better.
See Seamonkey bug 46177 (w/ patch). The problem was that gif/png icons have to converted first.
Sorry, I must have missed that bug. Perhaps because Mozilla doesn't show favicons on the bookmarks menu, even for Windows, so I assumed this would be a Firebird-only thing. Should I leave this bug open, or dupl it against the other bug? The other bug doesn't necessarily guarantee favicon support, and it also seems to have been inactive for most of 2 years.
Don't dupe it against Seamonkey (Bookmarks service is long since forked). Confirming, I don't know if this is feasible/possible, but it can go on the buglist for now.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I only just realized that Safari (which I don't normally use) adds favicons to the bookmarks menu, so it's definitely feasible. I've never coded for OS X before, but the Apple Developer Connection article: http://developer.apple.com/documentation/mac/Toolbox/Toolbox-101.html#MARKER-9-317 makes it sound simple to do. But perhaps that's because I don't understand enough about it ;)
Flags: blocking1.0?
it'd be nice, but it's somewhat difficult right now given our widget implementation. after 1.0.
Flags: blocking1.0? → blocking1.0-
Priority: -- → P3
Target Milestone: --- → After Firefox 1.0
(In reply to comment #0) > Unless this is currently impossible with OS X ? I'm not sure. (In reply to comment #7) > I only just realized that Safari (which I don't normally use) adds favicons to > the bookmarks menu, so it's definitely feasible. Camino does it very well and fast, for a long time already (except for general caching issues coming from Mozilla). But I think the UI is written natively in Cocoa.
*** Bug 253260 has been marked as a duplicate of this bug. ***
*** Bug 259384 has been marked as a duplicate of this bug. ***
*** Bug 266477 has been marked as a duplicate of this bug. ***
*** Bug 282475 has been marked as a duplicate of this bug. ***
Another problem that the Camino people have fixed that the Mozilla/FireFox people find impossible.
(In reply to comment #14) > Another problem that the Camino people have fixed that the Mozilla/FireFox > people find impossible. Such things are much easier to do when you have a Cocoa application like Camino. As I think I understand it, in Firefox it will need XUL support first, which is why it can't just be added easily.
*** Bug 297372 has been marked as a duplicate of this bug. ***
This would be great to have as part of the mac improvements for 1.1.
Flags: blocking-aviary1.1?
It'd be nice, but I think it'd be extremely unlikely by 1.1 at this late stage. I suspect it'll still require a lot of background work before this is possible. Plus, if they're going to release 1.1 with issues like, for example, embedded applets drawing over tabs (bug 162134 comment 248), then I think other release issues have overtaken the original intent for 1.1 to be about "Mac polish". Maybe 1.2 will be ;)
This requiers some mac-menus code rewrite which isn't planed for 1.8, especially considering that we'll have to re-implement mac menus for 1.9 (as part of the switch to cocoa widgets).
Flags: blocking-aviary1.1? → blocking-aviary1.1-
Bug 46177 is now moved to Core instead of SeaMonkey, so duping to that one. *** This bug has been marked as a duplicate of 46177 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.