219982 - In function `CERT_FilterCertListByUsage':2607: warning: unused variable `dummyret'

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[timeless]

/swap/BEOS/mozilla/security/nss/lib/certdb/certdb.c
 In function `CERT_FilterCertListByUsage':
2607: warning: unused variable `dummyret'

Comment 1

[Wan-Teh Chang]

Bishakha, could you fix this?  Thanks.

Comment 2

[timeless]

Attachment: (Av1) remove it, the out var has all the info needed

Comment 3

[Wan-Teh Chang]

Bob, is it safe to ignore the return value of CERT_IsCACert() here?
I think it is, but I'd like you to confirm it.

We should add a (void) cast to make it clear that we are intentionally
ignoring the return value of CERT_IsCACert().

Comment 4

[Robert Relyea]

Yes, it would be more correct to cast the return to (void). The function is
clearly just recalculating the certType and not interested in whether or not the
cert is a CA.

bob

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <certdb.c>

This really is Av1 file, edited to add |(void) |.

Comment 6

[Wan-Teh Chang]

Fix checked in.

Checking in certdb.c;
/cvsroot/mozilla/security/nss/lib/certdb/certdb.c,v  <--  certdb.c
new revision: 1.58; previous revision: 1.57
done