Closed Bug 219982 Opened 16 years ago Closed 16 years ago

In function `CERT_FilterCertListByUsage':2607: warning: unused variable `dummyret'

Categories

(NSS :: Libraries, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: bishakhabanerjee)

References

Details

Attachments

(1 file, 1 obsolete file)

/swap/BEOS/mozilla/security/nss/lib/certdb/certdb.c
 In function `CERT_FilterCertListByUsage':
2607: warning: unused variable `dummyret'
Bishakha, could you fix this?  Thanks.
Assignee: wchang0222 → bishakhabanerjee
Bob, is it safe to ignore the return value of CERT_IsCACert() here?
I think it is, but I'd like you to confirm it.

We should add a (void) cast to make it clear that we are intentionally
ignoring the return value of CERT_IsCACert().
Yes, it would be more correct to cast the return to (void). The function is
clearly just recalculating the certType and not interested in whether or not the
cert is a CA.

bob
This really is Av1 file, edited to add |(void) |.
Attachment #131907 - Attachment is obsolete: true
Attachment #131907 - Attachment description: remove it, the out var has all the info needed → (Av1) remove it, the out var has all the info needed
Attachment #137554 - Flags: review?(wchang0222)
Blocks: buildwarning
No longer blocks: 90906
Severity: normal → trivial
OS: BeOS → All
Hardware: PC → All
No longer blocks: buildwarning
Attachment #137554 - Flags: review?(wchang0222) → review+
Fix checked in.

Checking in certdb.c;
/cvsroot/mozilla/security/nss/lib/certdb/certdb.c,v  <--  certdb.c
new revision: 1.58; previous revision: 1.57
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.9
You need to log in before you can comment on or make changes to this bug.