220372 - File toolbar button does not work until Thunderbird is restarted

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jon Henry]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20030925 Firebird/0.7+
Build Identifier: Mozilla Thunderbird 0.3 (20030924)

When adding the File button to the Toolbar for the first time, clicking on it
will only result in a tiny gray box coming out of it rather than a menu
containing all the mail accounts/mail boxes to which the message could be moved.
Closing and re-opening Thunderbird will cause the File button to start
functioning properly.

Reproducible: Always

Steps to Reproduce:
1. Add the File button to Thunderbird's toolbar.
2. Click the button.

Actual Results:  
Tiny, empty gray menu comes out of the button.

Expected Results:  
List all folders to which the message could be moved.

Comment 1

[Jon Henry]

I neglected to mention that this only affects Thunderbird, adding the File
button in MailNews (Edit > Preferences > Mail and Newsgroups) works the first time.

Comment 2

[Alexey Chernyak]

This happens not when adding File button to the Toolbar for the first time, but
*whenever* you add File button to the toolbar.

Comment 3

[Jon Henry]

Attachment: Patch

This patch seems to fix things. The code to add a datasource to the File
button's tree was only getting called on startup, which didn't account for it
not existing at startup and being added dynamically later by customizing the
toolbar.

Comment 4

[Scott MacGregor]

Comment on attachment 148874 [details] [diff] [review]
Patch

sweet. thanks jon

I'll check this in.

Comment 5

[Scott MacGregor]

fixed

Comment 6

[trix supremo]

verified on latest 20041124 builds