220717 - -moz-image-region isn't inherited/cascaded properly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

-moz-image-region isn't inherited properly in some cases since the copy
constructor of nsStyleList doesn't copy it.  At least I think that's the case.

When I attempted to fix this, the dropdowns on the back and forward buttons broke.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: inheritance testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I wouldn't be surprised if there are other regressions I didn't catch.	I
should probably look through who else uses -moz-image-region.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Technically we should probably specify -moz-image-region wherever a
list-style-image is specified.  I'm not sure if I want to do that, though.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132593 [details] [diff] [review]
patch

r=bzbarsky

We could also hack things such that setting list-style-image would
automatically reset the moz-image-region to auto... Seems pretty hacky,
though...

Comment 5

[Hixie (not reading bugmail)]

Have I mentioned recently how list-style-image is TOTALLY the wrong property for 
this? We should be using 'content'...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 139071 [details] [diff] [review]
patch

This differs from the previous patch only by making the same changes in toolkit
as were in themes/classic.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 139071 [details] [diff] [review]
patch

sr=[e-mail]

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-01-14 18:23/24/25 -0800.

Comment 10

[Bill Mason]

This fix is believed to have caused a Firebird regression, bug 231144.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I need to look into the issues mentioned here and try to do this:

[16:33:16] <swalker> dbaron: did you post anything to themers about
-moz-image-region: auto?
[16:34:09] <dbaron> swalker: no.  Do external themes use -moz-image-region?
[16:34:38] <swalker> dbaron: I'd assume so
[16:35:01] <NeilAlmostZZZ> dbaron: several, if the posts on n.p.d.skins are
anything to go by
[16:35:12] <swalker> dbaron:
http://forums.mozillazine.org/viewtopic.php?p=337953#337953
[16:36:05] <dbaron> swalker: and how does one contact "themers"?
[16:36:29] <swalker> dbaron: your guess is as good as mine
[16:36:34] <swalker> dbaron: newsgroups?
[16:45:40] <michaell> dbaron, swalker: I think most of the regular "themers"
read the "Themes" mozillazine forum
[16:46:32] <michaell> a post in the relevant newsgroup would almost certainly
get picked up and reposted there...

Comment 12

[Scott MacGregor]

hey david, I think this broke toolbar drop down buttons in thunderbird. All of
my menu popups for mail toolbar buttons look messed up. Screenshot coming up.

Effected buttons: Security, Attach and Mark as Read

Comment 13

[Scott MacGregor]

Attachment: screenshot of the problem

Comment 14

[Scott MacGregor]

Attachment: fix menu.css for thunderbird bustage

This patch seems to make things better for thunderbird. David, can you look
over the changes and make sure they are all required?

Thanks to Stephen Walker for helping me out with this.

Comment 15

[Scott MacGregor]

patch to fix tbird issues has been checked in.

Comment 16

[Stephen Walker]

Attachment: Port the menu.css changes for seamonkey