221312 - context menu should include Select All

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P3)

Description

[:deanis74]

Right now, Select All only appears when there's some text selected.  It doesn't
make sense to have to select text to get the option of selecting all text.

20031002

Comment 1

[Mike Connor [:mconnor]]

-> noririty for now, he checked in a patch for this that got backed out, don't
think there was a bug for it though

Comment 2

[R.J. Keller]

Attachment: Patch

The patch :). Sounds simple enough.

Comment 3

[R.J. Keller]

--> me

moving over to my plate. This is something that has annoyed me for awhile and
I'd like to get it in.

Comment 4

[:deanis74]

Blake, thoughts?

Comment 5

[:deanis74]

This should block 1.0.

Re: the patch, should we always be showing context-sep-selectall as well?

Comment 6

[Peter Lairo]

Suggested criteria for NOT including something in the context menu:
If a function is used very rarely by most users (like "select all") or there
exists a keyboard shortcut that is easily reached with only the left hand
(CTRL+A), then it should NOT be included in the context menu.

Therefore -> WONTFIX?

"Remove 'Select All' from context menu when some text is selected" should be
another bug, since that is not what this bug's summary is requesting. 

BTW: I honestly don't see why this should be "blocking" Firefox 1.0. I would
much rather see the "Back" context menu added to cases where the mouse is over
an image, since some sites have many or large images, making context menu
navigation very difficult (must find a place where there is no image).

Comment 7

[Corwin K. Watts]

Peter, 
I hearily disagree with your statement that this should be WONTFIX. First off,
how rare is rare? Just because you and many others use keyboard shortcuts,
doesn't mean that others do. I like having select all as a context menu choice.
But by your logic, why should cut, copy and paste be in the context menu, or
back/forward for that matter.

As to your desire to have "back" (what about forward, etc.?) removed from image
context menus, file a bug.

Comment 8

[Peter Lairo]

(In reply to comment #7)
> First off, how rare is rare? 

Good question. It would be good to have statistics on this (i couldn't find any
with google :( ). But lacking those, I go by my impressions based on years of
experience and observations of others.

> But by your logic, why should cut, copy and paste be in the context menu, or
> back/forward for that matter.

cut, copy and paste are *very* common commands (http://tinyurl.com/27sce "The
most common task that keyboard shortcuts were used to perform was pasting"); and
they require slightly more effort to perform by KB (I have to twist/raise my
elbow to reach the CTRL+x/c/v keys - but not for CRTL+A)

> As to your desire to have "back" (what about forward, etc.?) removed from
image context menus, file a bug.

Done: bug 250193 - check out the first screenshot there ;)

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 138228 [details] [diff] [review]
Patch

showing this in all cases is a bad idea.

The "normal" context menu should have it, though.

Comment 10

[:deanis74]

(In reply to comment #9)
> (From update of attachment 138228 [details] [diff] [review])
> showing this in all cases is a bad idea.
> 
> The "normal" context menu should have it, though.

By "normal" do you mean both when text is selected and not selected?  How about
this logic?

this.showItem( "context-selectall", !( this.onLink || this.onImage ) );

Comment 11

[Mike Connor [:mconnor]]

I think that's about right, actually.  The link/image menus are still
overloaded, although one or the other is now better due to some recent tweaking.

Comment 12

[:deanis74]

Attachment: simple change to browser.js

This works much better for me.

Comment 13

[:deanis74]

Comment on attachment 153233 [details] [diff] [review]
simple change to browser.js

Mike, this OK with you?

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 153233 [details] [diff] [review]
simple change to browser.js

yeah, that seems plenty sane.

Comment 15

[:deanis74]

Fixed on branch.  Waiting for trunk to re-open.

Comment 16

[:deanis74]

Fixed