221360 - support F5 and/or F9 for checking mail

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, enhancement, P2)

Description

[Mike Connor [:mconnor]]

If renaming a folder can claim a function key, we should allow for such a key
for checking mail (inherently more useful)

Outlook/Outlook Express use F5
Lotus Notes/Ximian Evolution use F9

F5 and possibly F9 as well would be nice (I still hit F9 out of reflex after
spending a few years relying on Notes daily).

Comment 1

[Mike Connor [:mconnor]]

really, its an enhancement... Scott, I'd be glad to write the patch for this,
just assign it back to me if you'd prefer that

Comment 2

[Scott MacGregor]

I'd probably be interested in a windows only patch that uses F5. I seem to
remember OSX folks getting mad about our apps stealing function keys.

So use #ifdef XP_WIN in the XUL for F5.

Thanks Mike.

Comment 3

[Scott MacGregor]

oops and I guess F9 on linux since that's what ximian does...using the xul
pre-processor to ifdef it there too.

Comment 4

[Mike Connor [:mconnor]]

-> me

Comment 5

[Scott MacGregor]

not a 0.6 stopper but will take a patch if it happens before 0.6.

Comment 6

[Jon Henry]

Attachment: Patch

I think this does the trick. Apologies if mconner was working on this, but it
looked like it slipped off the radar and is something that was bugging me :).

Comment 7

[Scott MacGregor]

fixed

thanks for the patch

Comment 8

[trix supremo]

scott: F9 in linux 20041124 build works but F5/F9 on win32 20041124 build does
not. its not my impression from the comments that this was a linux only fix.

Comment 9

[Scott MacGregor]

F5 is working for me on windows. weird! i see text in the status bar saying No
New messages after I press F5. 

F9 should not work on linux. That's windows only. 

Comment 10

[trix supremo]

i see what my problem was.  The "...no new messages..." text was already present
initially so was unable to recognize if a Get was sent.  F5 works for me. 
Verified on 20041124 builds