223277 - Cut/Copy/Paste keyboard commands (Ctrl-X/C/V) from address/location/URL bar fails

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[David A. Cobb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031022 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031022 Firebird/0.7+

With the address in the AB highlighted, Ctl+c or Ctl+x would be expected to copy
the URI to the clipboard.  They do not, the previous content of the clipboard is
undesturbed.

Reproducible: Always

Steps to Reproduce:
1. Launch an app such as Notepad to provide a place to paste into;
2. Copy some recognizable text to the clipboard;
3. In Firebird, select the URI in the address bar [AB];
4. Either Ctl+c or Ctl+x;
5. Go to the Notepad app and paste (Ctl+v) the clipboard contents.

Actual Results:  
The original (step 2) contents of the clipboard are pasted.
Also, when using Ctl+x [cut] the string was not removed from the AB.

Expected Results:  
The URI copied from the AB in step 4 should be pasted. If Ctl-x was done, it
should have cleared the AB.

Comment 1

[Jon Henry]

Tweaking summary, OS

Confirmed on Win2000, 20031022 build. It should be noted that you also cannot
paste into the URL bar using Ctrl-V. This is a regression from yesterday's build
as far as I can tell. Also, the bug is Firebird only, today's Mozilla nightly
works fine. There were some giant checkins over the last couple days, but my
suspicion is that bug 200884 broke things, its changes to autocomplete.xml deal
specifically with ignoring Ctrl -key combinations.

Comment 2

[Jon Henry]

CC'ing Chanial...I apologize for the spam if you had nothing to do with this,
but the checkin of this code looked like a likely suspect to my untrained eye:

// this handler is called before the one in search.xml                
// that's sucks because the next line will also cancel                
// keys like ctrl-L, ctrl-N in the search bar.                        

if (aEvent.ctrlKey || aEvent.metaKey || aEvent.altKey)
  return false; // don't capture key + modifiers

Am I onto something?

Comment 3

[Steffen Wilberg]

Tweaking summary some more; -> toolbars; -> major.
Reassigning to Pierre (and toolbar QA).

Workaround: Right-Click in the location bar, select cut/copy/paste.

Comment 4

[Pierre Chanial]

yup, I know I introduced this problem.
I will fix it soon.

Comment 5

[Andrew Benton]

I don't see this bug on my Linux build Mozilla/5.0 (X11; U; Linux i686; en-US;
rv:1.6a) Gecko/20031022 Firebird/0.7+ (persist,gtk2+xft)

Comment 6

[Andrew Benton]

Sorry for that last comment, I didn't follow the instructions properly. I can
reproduce this bug.

Comment 7

[Shahar Goldin]

Using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031018 Firebird/0.7 

I'm experiancing a similar problem, where ctrl+c and such work, but it should
put it in the middle-click buffer if I select the text in the address bar

Comment 8

[Mike Tigas]

I saw exactly what Jon saw (comment 2) in autocomplete.xml (around line
325-340ish).  And yes, it is control-key specific; shift-insert works to paste
in the address bar.

I'm going to overnight autobuild a build with a backout of the patching from bug
200884 if anyone's interested.  (Of course they are, I hear everyone
complaining.)  Backing out the changes to bug 200884 seemed like a good
temporary solution for custom builders.

http://forums.mozillazine.org/viewtopic.php?t=31209

Comment 9

[Pierre Chanial]

/me bets it will be fixed tonight

Comment 10

[Pierre Chanial]

fixed. I should have earn money, here. :)

Comment 11

[Steffen Wilberg]

Thanks Pierre, works again. -> verified.
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=10%2F23%2F2003+23%3A55&maxdate=10%2F23%2F2003+23%3A55

Comment 12

[Mike Connor [:mconnor]]

*** Bug 223534 has been marked as a duplicate of this bug. ***