224188 - selector html* parsed as html * (universal selector implies combinator)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Hixie (not reading bugmail)]

The following CSS:

   html* { color: red; }

...is not ignored. It should be. Those two type selectors have no combinator 
between them. See data: testcase in URL.

Comment 1

[Hixie (not reading bugmail)]

(broke out of opera bug 130146 -- opera used to have this bug too but recently 
fixed it)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Um, this used to be correct, and http://dbaron.org/css/test/univsel tests for
it.  Did the spec change, or are we now considering 5.5 to override the grammar
rather than the other way around?

Comment 3

[Hixie (not reading bugmail)]

Well, where's the combinator?

Comment 4

[Anne (:annevk)]

I propose invalid, based on CSS2.1
<http://www.w3.org/TR/CSS21/selector.html#descendant-selectors>:

>matches a P element that is a grandchild or later descendant of a DIV element.
>Note the whitespace on either side of the "*" is not part of the universal
>selector; the whitespace is the descendant selector indicating that the DIV must
>be the ancestor of some element, and that that element must be an ancestor of the
>P.

Comment 5

[Anne (:annevk)]

Oops, it is _correct_ based on CSS2.1. I think I mixed my comment up with the
things said in comment 2, sorry.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 134738 [details] [diff] [review]
Proposed patch

As far as I can tell, both 5.5 and the CSS2.1 grammar agree with hixie here...

Note that the CSS2 grammar does NOT agree with either 5.5, Hixie, or the CSS2.1
grammar.  In CSS2, we have:

combinator
  : '+' S* | '>' S* | /* empty */
  ;

while in CSS2.1 we have:

combinator
  : PLUS S*
  | GREATER S*
  | S+
  ;

So in fact it looks like the spec changed...

Comment 8

[Hixie (not reading bugmail)]

Ah yes, that rings a bell. The CSS2 prose and syntax contradicted themselves, IIRC.

Comment 9

[Boris Zbarsky [:bzbarsky]]

taking.

Comment 10

[Boris Zbarsky [:bzbarsky]]

checked in.