Closed
Bug 224242
Opened 21 years ago
Closed 21 years ago
CSS "signature" needed
Categories
(Bugzilla :: User Interface, enhancement)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: mrmazda, Assigned: justdave)
References
Details
Attachments
(1 file, 2 obsolete files)
|
860 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Body tag on all pages should contain id="bugzilla-mozilla-org", which would
enable users via user css to customize the look and function of of bugzilla
pages on their systems.
This concept was developed on Eric Meyer's css mailing list and
http://tinyurl.com/t2do , and is explained at
http://archivist.incutio.com/viewlist/css-discuss/13291.
In my own case, it would permit me to retain use of my ideal choice of monospace
font size for mailnews, while using a smaller monospace font on bugzilla
show_bug pages, eliminating the annoying, normally present, horizontal scroll in
my usual 900px wide viewport.
Product and component for this bug suggested by myk@mozilla.org.
|
||
Comment 1•21 years ago
|
||
Note that this isn't specific to bugzilla.mozilla.org. This feature would be
useful for Bugzilla in general. For b.m.o, I've added the necessary tag
manually, as you'll see if you view the source of this page (but don't resolve
the bug, since we still have to come up with a solution for Bugzilla overall.
|
Assignee | |
Comment 2•21 years ago
|
||
This is live at http://landfill.bugzilla.org/bzdave/ if you want to see the
results.
|
||
Comment 3•21 years ago
|
||
MrMazda, you might want to help me push bug 53009 so you avoid going blind, too :-)
-> dave
Assignee: myk → justdave
|
|
Assignee | |
Updated•21 years ago
|
Attachment #134520 -
Flags: review?(myk)
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 134520 [details] [diff] [review]
Patch
>Index: template/en/default/global/header.html.tmpl
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
>retrieving revision 1.20
>diff -u -r1.20 header.html.tmpl
>--- template/en/default/global/header.html.tmpl 3 Jul 2003 21:31:50 -0000 1.20
>+++ template/en/default/global/header.html.tmpl 30 Oct 2003 22:46:08 -0000
>@@ -89,7 +89,8 @@
> # but set the bgcolor and onload attributes in the DEFAULT directive above.
> #%]
>
>- <body bgcolor="[% bgcolor %]" onload="[% onload %]">
>+ <body bgcolor="[% bgcolor %]" onload="[% onload %]"
>+ id="[% Param('urlbase').replace('^https?://','').replace('/$','').replace('[@:/.]','-') %]">
Nit: I like to see ID attributes appear as the first element in the attribute
list since they seem somehow more fundamental than other attributes.
Also, you might want to do one more replace to make sure there aren't any
illegal characters in the string per section 6.2 of the HTML 4 spec, which says
"ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by
any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons
(":"), and periods (".")."
That's seems unlikely to happen very often, however, so I'm fine with this
version too. r=myk
Attachment #134520 -
Flags: review?(myk) → review+
|
||
Comment 5•21 years ago
|
||
Do we not have a css_class_quote filter for converting text into a valid CSS
class/id name?
Note that this interacts with the class-based stuff for component/bug_id etc.
over in bug 223078.
Gerv
|
||
Comment 6•21 years ago
|
||
Attachment #134520 -
Attachment is obsolete: true
|
|
||
Comment 7•21 years ago
|
||
Comment on attachment 135839 [details] [diff] [review]
Zach's patch with jouni's comments
Sorry, wrong bug number - ignore the comment above.
Attachment #135839 -
Attachment is obsolete: true
|
|
||
Updated•21 years ago
|
Flags: approval+
|
|
||
Updated•21 years ago
|
Attachment #134520 -
Attachment is obsolete: false
|
|
Assignee | |
Comment 8•21 years ago
|
||
Comment on attachment 134520 [details] [diff] [review]
Patch
it's bitrotted...
Attachment #134520 -
Attachment is obsolete: true
Attachment #134520 -
Flags: review-
|
|
Assignee | |
Comment 9•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #140534 -
Flags: review?(myk)
|
|
||
Comment 10•21 years ago
|
||
Comment on attachment 140534 [details] [diff] [review]
Patch v2
Works, looks good, r=myk
Attachment #140534 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 11•21 years ago
|
||
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
<-- header.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 12•21 years ago
|
||
So now that this is fixed, will anyone using v2.17.6+ automatically have this
enabled? qa.mandrakesoft.com (using 2.17.4) needs it, and I'm wondering about
duplicating this bug there.
|
|
Assignee | |
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.18
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•