224825 - Message not delete-able in standalone message window after compacting its folder

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[Jonathon M. Merz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20031007 MultiZilla/1.5.0.3l
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20031007 MultiZilla/1.5.0.3l

When a folder is compacted while a message in that folder is open in a
standalone message window, two things happen:
1. The message cannot be deleted from the standalone window it appears in.  The
<Delete> key, the delete button on the toolbar, and Edit->Delete Message all do
nothing.  (No error in javascript console either, FYI).
2. The message /can/ be deleted from the message list, but the message displayed
in the standalone window is not advanced as usually happens.

Reproducible: Always

Steps to Reproduce:
1. In a folder with three or more messages, open a message that is not the last
message in the folder list in a standalone window.

2. Delete one or more messages from the folder.  Do not delete the message being
viewed in the standalone window, and make sure there is still at least one
message left after the viewed message in the folder list. (This is to make sure
that the folder will be compacted in the next step.)

3. Compact the folder (File->Compact Folders)

(NOTE: steps 4a and 4b are alternative steps to demonstrate the two symptoms)
4a. In the standalone window, try to delete the message using the <Delete> key,
the Delete button in the toolbar, or Edit->Delete Message.  (See Actual and
Expected Results Part I here)

4b. In the folder list, highlight the message that is viewed in the standalone
window and delete it.  (See Actual and Expected results Part II here.)

Actual Results:  
Part I:
After step 4a, nothing happens.  The message is not deleted.

Part II:
After step 4b, the message is deleted, but the standalone window continues to
display the same message.

Expected Results:  
Part I:
After step 4a, I expect that the message is deleted, and the standalone window
then displays the next message, or if the message was the last message in the
folder, the standalone window disappears.

Part II:
If step 4b is performed instead of 4a, I expect that the standalone window
advances to the next message, or if the now-deleted message was the last message
in the folder list, the standalone window disappears.

Workaround:

Closing and re-opening the standalone message window after compacting the folder
restores normal behavior.

Comment 1

[Mike Cowperthwaite]

Both symptoms described ("4a" and "4b") are dependent on the folder having been 
compacted.

Comment 2

[greg]

This bug is present in Thunderbird, version 2 beta 2 (20070116), running on Windows XP. Very annoying.

Comment 3

[Mike Cowperthwaite]

It's not just 'delete', of course -- it's all the functions.

When I try Reply, I get this error (2pre-0308):
==========
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMessenger.msgHdrFromURI]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: ComposeMessage :: line 212"  data: no]
==========

Forward gives both the above error and this one:
==========
Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMessenger.msgHdrFromURI]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: ComposeMessage :: line 212"  data: no]
Source File: chrome://messenger/content/mailCommands.js
Line: 212
==========

Moving to Core.

Comment 5

[Dennis Bautell]

Bump with a Me-Too.
Seems to apply to both mail and RSS feeds, and also when more messages are downloaded. I'd broaden the scope: if I am viewing a message in the separate window and something happens to change the folder, then I can't delete the message from within that window. Can't speak to forward/reply.

2.0.0.18 (20081105) on XP. No add-ons, some sorting filters. Have previously immigrated the profile over from Linux, but doubt any relevance.

Comment 7

[WADA:World Anti-bad-Duping Agency]

FYI.
If Shredder, Bug 520115 occurs and standalone window disappears. So this bug can't happen on current Shredder.

Comment 8

[Tim Deaton]

I'm now using version 2.0.0.23 (20090812) on Windows 7rc (build 7100), and (still) at least half the time the [Delete] icon appears to do nothing when I hit it.  Yet when I close the message, it has disappeared from the inbox and moved to the trash folder.  

I first reported a variation of this as a secondary comment to bug 392640 on 2007-11-26 19:09:08 PDT.  Got no response, forgot about that entry, & later created the bug quoted below.

-- Tim Deaton

copied from "dup" bug 458335:
 Description From  Tim Deaton   2008-10-02 20:23:58 PDT   (-) [reply] 

For longer than I can remember, it's just seemed like some sessions the
DeleteMessage "X" in the message-viewing window worked, and some sessions it
didn't.

When I open Thunderbird and download messages, it seems like Thunderbird waits
til I delete one message and then runs its compactor routine.  That's okay if I
quit back to the list, then deleted the message, and then the compactor ran. 
But if I'm going thru several messages and just hit the DeleteMessage "X" icon
to delete that one and go to the next, and if the compactor runs while I'm
reading one of those messages, then the "X" (delete message) icon quits
working.  Then, for the rest of the session, I have to read the message, quit
the message, THEN delete the message, then open the next message.



Reproducible: Always

Steps to Reproduce:
1. Start session
2. Download messages
3. Start reading messages
4. Delete message using the DeleteMessage icon in the message-viewing window
5. While viewing subsequent message, the Compactor runs
6. The DeleteMessage icon no longer works.

Actual Results:  
6a. Most of the time, I then have to quit back to the list of messages and
delete the message from there.
6b. Sometimes it APPEARS to not work, but when I quit back to the list, that
message I tried unsuccessfully to quit out of is now gone from the list.

Expected Results:  
That message should disappear (like it does at other times) and the next
message would be displayed in the viewing window.  [NOTE: This is a separate
window.  For safety reasons, I NEVER allow the "message pane" (that shares the
screen with the list of messages) to be open.]

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to WADA from comment #7)
> FYI.
> If Shredder, Bug 520115 occurs and standalone window disappears. So this bug
> can't happen on current Shredder.

Tim recently replied that he sees this when using v3.1.10. wada, does that change your opinion of Bug 520115?

Comment 10

[WADA:World Anti-bad-Duping Agency]

(In reply to Wayne Mery (:wsmwk) from comment #9)
> (In reply to WADA from comment #7)
> > FYI.
> > If Shredder, Bug 520115 occurs and standalone window disappears. So this bug
> > can't happen on current Shredder.
> 
> Tim recently replied that he sees this when using v3.1.10. wada, does that
> change your opinion of Bug 520115?

As I wrote in Bug 520115 comment #7, problem of Bug 520115 comment #0 occurred in Tb 3.0pre but it didn't occur in Tb 3.1.1, if offset of the opened mail(local mail folder) is not changed by compact.
Wayne, please distinguish compact-does-do-nothing case(deleted mail required to invoke compact) and offset-not-changed-by-compact case and offset-changed-by-compact case, please.
If Tb trunk, as I wrote Bug 520115 comment #9, error & window close happened in both offset-not-changed-by-compact case and offset-changed-by-compact case. It was same in Tb 6. 
So, this bug still can't occur in Tb 6 or newer because srandalone window is closed after compact(== Bug 520115), if compact is really executed on relevant local mail folder.

As I tested with "Compact of context menu of local mail folder", sorry but I don't know IMAP case nor "Compact Folders" case. IMAP case may be different.

Comment 11

[Wayne Mery (:wsmwk)]

I cannot reproduce Part I, so I assume no point in testing other items.

After deleting (after compact) in standalone window AND in message list see 
: Component returned failure code: 0x80550008 [nsIMsgDatabase.IsIgnored]

... which must be because of the open SA window item, because no error if not SA window is ope

Comment 12

[Wayne Mery (:wsmwk)]

So this shouldn't be happening. If someone still sees it when compoact is NOT in progress, we'll need more information